Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 630624196F3 for ; Wed, 14 Apr 2010 00:44:21 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=5 tests=[BAYES_20=-0.001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id adZ0A+u7idWA for ; Wed, 14 Apr 2010 00:44:20 -0700 (PDT) Received: from homiemail-a13.g.dreamhost.com (caiajhbdcbef.dreamhost.com [208.97.132.145]) by olra.theworths.org (Postfix) with ESMTP id 7EF96431FC1 for ; Wed, 14 Apr 2010 00:44:20 -0700 (PDT) Received: from sspaeth.de (unknown [195.190.188.219]) by homiemail-a13.g.dreamhost.com (Postfix) with ESMTPA id 88C416A805F; Wed, 14 Apr 2010 00:44:18 -0700 (PDT) Received: by sspaeth.de (sSMTP sendmail emulation); Wed, 14 Apr 2010 09:44:16 +0200 From: "Sebastian Spaeth" To: Carl Worth , Notmuch list Subject: Re: [PATCH] RFC: User-Agent header In-Reply-To: <87bpdnl02k.fsf@yoom.home.cworth.org> References: <87iq821hba.fsf@SSpaeth.de> <87hbnhprk0.fsf@SSpaeth.de> <87y6gtnkch.fsf@SSpaeth.de> <87bpdnl02k.fsf@yoom.home.cworth.org> Date: Wed, 14 Apr 2010 09:44:16 +0200 Message-ID: <87iq7ubhrj.fsf@SSpaeth.de> User-Agent: notmuch version 0.1-107-g553feae (Emacs 23.1.1/x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2010 07:44:21 -0000 On 2010-04-13, Carl Worth wrote: > > OK, final post from me on this issue. > No, wait! I want more from you. :-) Sigh, they always want more :-) > Would you care to put together a solution that does this from within > notmuch*.el ? I really want things usable by default without people > having to hack up their .emacs files. See the "sister mail" to this thread, in which I simply added the whole shebang to notmuch.el (not using a lambda function). Is that what you had in mind. Mind you, my elisp knowledge borders close to 0, so I would be surprised if I did not botch up things. However, I have tested the patch, and the User-Agent header got inserted. > Of course, we could also easily add a variable to make this not happen, > (but that can be added in a follow-on patch by anyone). Some don't want it, but it cannot be disabled in this patch, so that would indeed need to be a followup patch. This gets now inserted (message mode automatically wrapped the header like this): User-Agent: notmuch version 0.1-107-g553feae (Emacs 23.1.1/x86_64-pc-linux-gnu) Is that an acceptable format? I would have preferred to not include the "version" string, but notmuch --version spits that out, and it was just easier to leave it in. Is that "version" really needed, BTW? Why can't notmuch --version not just say: notmuch 0.1-107-g553feae Sebastian