From: Carl Worth <cworth@cworth.org>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Subject: Re: MIME restructuring [was: Re: release-candidate/0.6]
In-Reply-To: <87liy6bbug.fsf@yoom.home.cworth.org>
References: <8762pn7gth.fsf@servo.factory.finestructure.net>
	<874o4zczr8.fsf@yoom.home.cworth.org>
	<87wrhvyqfn.fsf@servo.factory.finestructure.net>
	<87r57ybcna.fsf@yoom.home.cworth.org>
	<4DD18DFE.7090206@fifthhorseman.net>
	<87liy6bbug.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Tue, 17 May 2011 16:05:48 -0700
Message-ID: <87ei3x9bcj.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 16 May 2011 13:59:51 -0700, Carl Worth <cworth@cworth.org> wrote:
> So what I'd love to see from here is a commit with a description like
> the above, and then a test case looking like your example.
>=20
> From there, I'd next like a new version of the commit that gets the
> intended behavior with less code duplication.
>=20
> I'll work on each of the above unless someone beats me to any of it. Let
> me know.

I've now pushed out my own version of the MIME restructuring feature.

It differs from what was presented here in avoiding the code
duplication.

It also provides properly nested mutlipart/* output for the
=2D-format=3Dtext case. That's not that I expect anybody to *do* anything
with that nested output, just that it was cleaner and easier to fix both
text/json at the same time, (and avoiding doing that is perhaps what led
to the original code duplication).

I also cherry-picked in a piece of later patch from Jamie so that the
existing emacs tests still pass. And I updated the documentation for
this new feature.

So I'm happy with this new feature now, (which I know provides an
essential part of the basis for the rest of the crypto branch).

From=20here, I'm hoping that my review of the rest of Jamie's
release-candidate branch goes faster. The general shape of the commits
and commit messages looks pretty good to me, so I think it will.

I think there are still features added here and there without
corresponding test cases (multipart/alternative is one that comes to
mind) and perhaps without updated documentation (--decrypt is at least
documented---but I do think it's strange that it's documented to only
work for json output).

More from me tomorrow.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk3S/0wACgkQ6JDdNq8qSWh8NgCfTJYFQXSq70KNgDoPLsv9iduj
/wkAn2rHXxF15uhiwVdy9VENwbjeb/px
=yNBm
-----END PGP SIGNATURE-----
--=-=-=--