Return-Path: <prvs=jrosenthal=7218428b9@jhu.edu>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 6AD164196F2
	for <notmuch@notmuchmail.org>; Thu, 22 Apr 2010 07:14:19 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.301
X-Spam-Level: 
X-Spam-Status: No, score=-2.301 tagged_above=-999 required=5
	tests=[BAYES_20=-0.001, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id TUPrRSGvKN8Q for <notmuch@notmuchmail.org>;
	Thu, 22 Apr 2010 07:14:18 -0700 (PDT)
Received: from ipex3.johnshopkins.edu (ipex3.johnshopkins.edu
	[128.220.161.140])
	by olra.theworths.org (Postfix) with ESMTP id A3B84431FC1
	for <notmuch@notmuchmail.org>; Thu, 22 Apr 2010 07:14:18 -0700 (PDT)
X-IronPort-AV: E=Sophos;i="4.52,256,1270440000"; d="scan'208";a="378218616"
Received: from c-69-255-36-229.hsd1.md.comcast.net (HELO lucky)
	([69.255.36.229])
	by ipex3.johnshopkins.edu with ESMTP/TLS/AES256-SHA;
	22 Apr 2010 10:14:17 -0400
Received: from jkr by lucky with local (Exim 4.69)
	(envelope-from <jrosenthal@jhu.edu>)
	id 1O4xAW-0005eN-JY; Thu, 22 Apr 2010 10:14:16 -0400
From: Jesse Rosenthal <jrosenthal@jhu.edu>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>,
	Notmuch development list <notmuch@notmuchmail.org>
Subject: Re: sort order regression
In-Reply-To: <87bpdbmvj0.fsf@SSpaeth.de>
References: <87bpdbmvj0.fsf@SSpaeth.de>
Date: Thu, 22 Apr 2010 10:14:16 -0400
Message-ID: <87wrvz7ex3.fsf@jhu.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2010 14:14:19 -0000

On Thu, 22 Apr 2010 16:06:27 +0200, Sebastian Spaeth <Sebastian@SSpaeth.de> wrote:
> 
> jkr and I noticed that patch series are shown in reverse order now, in
> fact threads seem to display messages at the same depth in reverse
> chronological order now.

Just to follow up on this, it seems that the regression comes from the
fix Carl introduced in 2a1a4f0551 to make his simplification of my patch
(simplification = 36e4459a3 , my patch = 4971b85641) pass tests. The
question is whether my original, more complicated version would have
passed the tests without the regressing fix. I do know that it showed
the search order as expected.

Unfortunately, I'm not quite skilled enough at git to turn back some
files to a certain state, tests to another state, and so on.

Best,
Jesse