DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=TrwuLUJqJS0rygmRF5dzD9Mso1fgf5YIs/Hy328FRS4iwGXJ83e6JBAtzU4voZHS9l
	XPjau2kRXpOLG7ltIDltmd0IJVfUNNqmplkBZNOsD360D4VOf2zEIwGRblyOco/3afuU
	o7Qi0uotsbUBbJYljAvrHski812W6JA41froo=
MIME-Version: 1.0
In-Reply-To: <87sjyvk875.fsf@wsheee.2x.cz>
References: <AANLkTi=7eCt0=NqUiJFrGDcaZ17LOd3qNNqN1-ASwYzr@mail.gmail.com>
	<87sjyvk875.fsf@wsheee.2x.cz>
Date: Sat, 20 Nov 2010 18:38:21 -0500
Message-ID: <AANLkTin_6A1qnuFpE9oPXySA0j5jTV-tq=BbqSNMPWfb@mail.gmail.com>
Subject: Re: [PATCH] Implement a simple read-eval-print loop.
From: servilio <servilio@gmail.com>
To: Michal Sojka <sojkam1@fel.cvut.cz>
Content-Type: text/plain; charset=ISO-8859-1
Cc: notmuch <notmuch@notmuchmail.org>
Precedence: list

Hi Michal,

On 20 November 2010 16:15, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> On Sat, 20 Nov 2010, servilio wrote:
>> This implementation uses GNU readline for the prompt and command
>> history, with the default file completion enabled. GLib is used to
>> split the read line into an arguments list.
>
> Hi,
>
> I haven't tested it yet, but it seems to be exactly the piece of code I
> wanted to have to speed up notmuch-hello when notmuch is used remotely
> over ssh. Spawning new ssh for every saved search to get the count of
> matched messages has a way too big overhead. Is this the use case you
> had in mind when implementing this?

Great to see that you find it useful. Yes, the remote usage was in my
mind, but it should enhance the local usage as well. We could also
create a quicker test run using the shell.

The disadvantage of using an interactive shell is that you can have
only one operation running in the UI, and I see no way of
interrumpting an operation unless you kill the process, but as
starting a new shell shouldn't be a biggie, this might not be as
limiting as might seem.

The ideal would be for libnotmuch to be able to connect to a
xapian-tcpsrv, but haven't had time to look at than, and an
interactive shell seemed to be less time demanding to implement (and
had the subjective promise of providing a lot of fun).

> Currently, I have only one comment to the patch. For me, "repl" is a bit
> unintuitive. I was thinking about "shell" as the name of subcommand for
> this.

I agree, maybe "shell" or "interactive" would be more intuitive, but
when I started "repl" was the only one I could think of.

Servilio