DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:subject:in-reply-to:references:user-agent:date:message-id
	:mime-version:content-type;
	b=Oc2X8cOjN32QbQ9i5kwj7gyJ7kASXxxuWJjrhbnZBpYOVjpkhiwe0q22zyA8Kx4VUS
	47Nkr155cLPrKEj0T6EUcSVKhZFkM9QMynBoqmS0loE5uOKLzWCkX3w6RHdPoV1AuBHw
	/KVW3H7jzv49fs+5T9duSy+Vplc0/Auk+1Mnw=
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Carl Worth <cworth@cworth.org>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.
In-Reply-To: <87oc2ellzn.fsf@yoom.home.cworth.org>
References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-2-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-3-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-4-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-5-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-6-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-7-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-8-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-9-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-10-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-11-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-12-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-13-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-14-git-send-email-jrollins@finestructure.net>
	<1306619520-25730-15-git-send-email-jrollins@finestructure.net>
	<874o48yg28.fsf@yoom.home.c worth.org> <87lixkpw16.fsf@gmail.com>
	<87oc2ellzn.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5-208-g109ec1a (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 04 Jun 2011 00:22:04 +0400
Message-ID: <87ipsmpswj.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Fri, 03 Jun 2011 13:05:00 -0700, Carl Worth <cworth@cworth.org> wrote:
Non-text part: multipart/signed
> On Thu, 02 Jun 2011 10:49:57 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Well, it says that changes are in notmuch 0.5.  So "old" and "previous"
> > refer to pre-0.5 (i.e. 0.4) and "new" refers to 0.5.
> 
> Sure, but I happen to ahve already forgotten the details of how the
> variable could be configured in 0.4 and in 0.5. More importantly, anyone
> in the future reading the commit log is much more likely not to
> remember.
> 
> > Any configuration when `notmuch-fcc-dirs' is a list.  That variable has
> > a nice documentation.
> 
> Again, I'd like our commit messages to be self-contained. They are much
> more useful if the describe the change being made without assuming to
> much outside knowledge.
> 
> > > It would be easier to understand the code if there were a corresponding
> > > test case for it.
> ...
> > I do not think we need a test for this fix.  What we need are tests for
> > FCC functionality when notmuch-fcc-dirs is a list.
> 
> Yes!
> 
> > Old configuration format was changed in 0.5 in an incompatible way.
> > There is a check for the unsupported old-style configuration.  But the
> > check is broken and results in an error when running with a valid
> > new-style configuration.
> 
> This is actually what I meant by "corresponding test case". If the bug
> here is that a "new-style configuration" doesn't work , (and I still
> don't like that wording---don't say "new style"---explain what it
> actually *is*), then yes, we need a test case showing that bug.
> 
> > I am not sure what you expect from the commit message here.  IMO it is
> > enough for this small bugfix and those who interested can always refer
> > to documentation for details.
> 
> The commit message should provide a self-contained description of the
> change. It should be along the lines of:
> 
> 	When fcc-dirs is set to
> 	<some-particular-datatype-that-should-work> notmuch was
> 	incorecctly detecting this as the
> 	<old-style-that-is-no-longer-supported> and generating an error
> 	message. Fix the test so that this configuration now works.
> 
> Where the <phrases> above should be replaced with actual descriptions,
> not relative pointers to information like "old style" or "new style".
> 
> Does that make sense?
> 

"notmuch was incorecctly detecting this as the ..." is not right.  It is
a wrong-type-argument lisp error (evaluating (length '(a . b))).  How
about:

  Fix wrong-type-argument lisp error in `notmuch-fcc-header-setup' when
  `notmuch-fcc-dirs' is set to a list.  The error was in the
  `notmuch-fcc-dirs' format check which was changed in an incompatible
  way from 0.4 to 0.5.

Regards,
  Dmitry

> -Carl
Non-text part: application/pgp-signature