From: Tomi Ollila <tomi.ollila@iki.fi>
To: Servilio Afre Puentes <servilio@gmail.com>, Jani Nikula <jani@nikula.org>,
	notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH 0/2] Enhancements to notmuch-hello search history
In-Reply-To: <87ppx6lo6g.fsf@goose.CSU.McMaster.CA>
References: <87y5bwkml2.fsf@goose.CSU.McMaster.CA> <874nejrupr.fsf@nikula.org>
	<87ppx6lo6g.fsf@goose.CSU.McMaster.CA>
User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Sun, 05 May 2013 12:58:54 +0300
Message-ID: <m2li7teoip.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Sat, May 04 2013, Servilio Afre Puentes <servilio@gmail.com> wrote:

> Jani Nikula <jani@nikula.org> writes:
>
>> On Fri, 03 May 2013, Servilio Afre Puentes <servilio@gmail.com> wrote:
>>> Two patches that enhance the notmuch-hello search history UI. Though
>>> minor I find them very helpful.
>>
>> Both seem to work as advertised; I did not look at the code much.  A
>> minor bikeshed is that I think y-or-n-p would suffice in patch 1/2.
>
> I know, but as it clears the whole history I decided to go with a
> confirmation that required more attention to diminish the chance of
> accident, and the action is taken not so oftenly (at least for me, and
> my guess is that it is the same for most) so it stills balances out
> positively in the usability.

I tested the patch and it works as advertised.

I agree with Jani that y-or-n-p would suffice for clearing all
recent searches (but yes-or-no-p is not so bad as I originally thought
as C-g can be used to stop processing (typoing 'no' is too easy ;/). 

If we could use "undo" feature to restore last clear/del then I'd agree
100% with Mark (i.e. no y-or-n-p for [del]).

In any case fix at least the style issue Mark mentioned -- any of the
yes/no queries will eventually be fine with me (as I don't know without
experience what would be the best (for me) after all).

> Servilio

Tomi