Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 353B8429E25 for ; Mon, 27 Jun 2011 13:50:50 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5xOc2zl9V4uH for ; Mon, 27 Jun 2011 13:50:48 -0700 (PDT) Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C2BF6431FD0 for ; Mon, 27 Jun 2011 13:50:48 -0700 (PDT) Received: by qwb7 with SMTP id 7so3053298qwb.26 for ; Mon, 27 Jun 2011 13:50:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=W8Pfixbl+UMsUuGqFz3xiRbSOU/piFcnGOTXqCtE9+0=; b=StxDtHytmdAAlDeKpVxI6PeGWuk6DjwrY4LvB4ftglr9U4RKWzxWxuI4fBY6eW/Z// dS7Bof0B09SEuGKE54azDmMhUQHnWW78R3eJcvhDiXWWgmghglnCfG0PHLIrbrkowvaG skf8/T2I0igQtMQcq863AX0Eiaz1tsDygLpDY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=fLrx1b9OtwESP/KrZ6xrQVtTFWvTsrz7lfxp+RlMkomgPOj1+BGpcHvNrdFih8dnnT zQ40XSxG3YYWfLgktrVLToonl+2i6okFMHxRHf/80zNqIfKD67zdcqa6jEgciT9ZwZ6I r5hDbBpipGO4mqgAU76l5cOs2C887N9fwanyc= MIME-Version: 1.0 Received: by 10.229.126.229 with SMTP id d37mr3027436qcs.24.1309207847272; Mon, 27 Jun 2011 13:50:47 -0700 (PDT) Sender: amdragon@gmail.com Received: by 10.229.32.197 with HTTP; Mon, 27 Jun 2011 13:50:47 -0700 (PDT) In-Reply-To: <87vcvrw91f.fsf@gmail.com> References: <87vcvrw91f.fsf@gmail.com> Date: Mon, 27 Jun 2011 16:50:47 -0400 X-Google-Sender-Auth: xk4kz63n3Akg7hcEhxF1qvn6On8 Message-ID: Subject: Re: [PATCH] test:Improve test behaviors when --root is used From: Austin Clements To: Mark Anderson Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 20:50:50 -0000 This looks great (modulo one bug, below). I've wanted to run the tests on tmpfs before, but was too lazy to actually fix the tests. Given how easy it is to accidentally use "..", I wonder if there's a way to force people to use $TEST_DIRECTORY? On Mon, Jun 27, 2011 at 12:09 PM, Mark Anderson wrote: > --- a/test/symbol-hiding > +++ b/test/symbol-hiding > @@ -12,13 +12,13 @@ test_description=3D'exception symbol hiding' > =A0. ./test-lib.sh > > =A0run_test(){ > - =A0 =A0result=3D$(LD_LIBRARY_PATH=3D../../lib ./symbol-test 2>&1) > + =A0 =A0result=3D$(LD_LIBRARY_PATH=3D$TEST_DIRECTORY/../../lib ./symbol-= test 2>&1) Did you mean $TEST_DIRECTORY/../lib?