From: Carl Worth <cworth@cworth.org>
To: Jameson Graef Rollins <jrollins@finestructure.net>, Notmuch Mail
	<notmuch@notmuchmail.org>
Subject: Re: [notmuch] [PATCHv2] notmuch.el: colorize lines in
	notmuch-search based on thread tags.
In-Reply-To: <87r5p01pqb.fsf@servo.finestructure.net>
References: <87aavpb3wh.fsf@servo.finestructure.net>
	<87r5p01pqb.fsf@servo.finestructure.net>
Date: Wed, 07 Apr 2010 11:19:52 -0700
Message-ID: <874ojngm5z.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Thu, 04 Feb 2010 19:38:20 -0500, Jameson Graef Rollins <jrollins@finestr=
ucture.net> wrote:
> Arbitrary font faces can be specified for given thread tags.  By
> default, no coloring is applied.  To specify coloring, place something
> like this in your .emacs:
>=20
> (setq notmuch-search-line-faces '(("delete" . (:foreground "red"))
>                                   ("unread" . (:foreground "green"))))
>=20
> Order matters: line faces listed first will take precedence (in the
> example above, a thread tagged both "delete" and "unread" will be
> colored red, since the "delete" face is listed before the "unread").

Hi Jameson,

Thanks for this patch. I just pushed it (based on what I found
originally in spaetz' tree). Only after coming back here did I find that
you had sent a second version that colored "delete" tags by default.

I haven't added that part for a couple of reasons:

1. The commit message doesn't match the behavior of the patch, (it says
   "no coloring is applied" by default.

2. I think we'll go with a tag name of "deleted" rather than "delete".

I did fix up some indentation and a slightly scrambled commit
message. But maybe that only existed in spaetz' tree.

Finally, I checked the customization support, ("M-x customize", then
browse Applications->Email->Notmuch), and saw that notmuch-tag-face is
much easier to customize there, (provides a drop-down value menu with
buttons for modifying the face---where I couldn't even figure out how to
use customize for the new notmuch-search-line-faces).

Plus, I think both of these values should likely be merged into a single
face-selection option, (perhaps with a separate Boolean to determine
whether to highlight just the tag name or the whole line).

Thanks again for the improvements, and hopefully you'll see quicker
merging from me in the future.

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLvMzI6JDdNq8qSWgRAusUAKCB191Kj1GtR6BMhRtyfLY7eKWPjgCbBB6P
2krdMPmVGLV1RoN6dHHGrvM=
=+F6s
-----END PGP SIGNATURE-----
--=-=-=--