From: David Bremner <david@tethera.net>
To: Aaron Ecay <aaronecay@gmail.com>, David Edmondson <dme@dme.org>,
	Pieter Praet <pieter@praet.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Don't attempt to colour tags in
	`notmuch-show-mode'.
In-Reply-To: <m2zkdnbcbx.fsf@gmail.com>
References: <1325004434-24583-1-git-send-email-dme@dme.org>
	<87aa5nlwwg.fsf@praet.org>
	<cunmx9n51u4.fsf@hotblack-desiato.hh.sledj.net>
	<m2zkdnbcbx.fsf@gmail.com>
User-Agent: Notmuch/0.11+61~gbaa2c97 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 16 Jan 2012 18:21:24 -0400
Message-ID: <874nvvi90b.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Mon, 16 Jan 2012 15:51:30 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> On Mon, 16 Jan 2012 11:22:27 +0000, David Edmondson <dme@dme.org> wrote:
> > On Mon, 16 Jan 2012 12:17:03 +0100, Pieter Praet <pieter@praet.org> wro=
te:
> > > Alas, those text properties actually *were* effective (and I liked th=
em :)
> >=20
> > Well, not in emacs 24. My reading of the source was that overlays were
> > intended to stomp on text properties, but that could have been wrong.
> >=20
> > Do they look correct when you add/remove tags?
>=20
> The tags look nice and yellow-green for me too on a trunk build of emacs
> (which is one flavor of emacs 24).  Adding and removing tags works as
> expected =E2=80=93 the tags dis/appear and are the right color.
>=20
> I haven=E2=80=99t reloaded the notmuch *.el files since this change lande=
d, but
> I agree with Pieter that the overlays were nice.

I'm leaning to revert this patch. Any opposition?

d