Return-Path: <cworth@cworth.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 1AD0A4196F2
	for <notmuch@notmuchmail.org>; Wed, 14 Apr 2010 11:41:44 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.89
X-Spam-Level: 
X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
	tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
	autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id vvug4gcGHly2; Wed, 14 Apr 2010 11:41:43 -0700 (PDT)
Received: from yoom.home.cworth.org (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 31569431FC1;
	Wed, 14 Apr 2010 11:41:43 -0700 (PDT)
Received: by yoom.home.cworth.org (Postfix, from userid 1000)
	id D1A38568DE1; Wed, 14 Apr 2010 11:41:42 -0700 (PDT)
From: Carl Worth <cworth@cworth.org>
To: Dirk Hohndel <hohndel@infradead.org>, Tomas Carnecky <tom@dbservice.com>,
	Dirk Hohndel <hohndel@x200.gr8dns.org>
Subject: Re: [PATCH] Add strcasestr v.3 - add compat implementation of
	strcasestr
In-Reply-To: <m3mxx7azkb.fsf@x200.gr8dns.org>
References: <m3vdbvb8p7.fsf@x200.gr8dns.org> <4BC4BC26.1060803@dbservice.com>
	<m3mxx7azkb.fsf@x200.gr8dns.org>
Date: Wed, 14 Apr 2010 11:41:42 -0700
Message-ID: <87pr21g9ll.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2010 18:41:44 -0000

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 13 Apr 2010 13:05:08 -0700, Dirk Hohndel <hohndel@infradead.org> wr=
ote:
> On Tue, 13 Apr 2010 20:47:02 +0200, Tomas Carnecky <tom@dbservice.com> wr=
ote:
> > On 4/13/10 6:47 PM, Dirk Hohndel wrote:
> > > v.3 of this patch, now with the changes to makefiles, configure script
> > > compat.h and all new files that I need
> > > Please test on platforms lacking strcasestr
...
> > Tested-by: Tomas Carnecky <tom@dbservice.com>
>=20
> Thanks Tomas, I really appreciate it.

Thanks to both Dirk and Thomas for this portability fix.

I've pushed it now, with a few minor changes:

  * Delete trailing whitespace

  * Add include of "compat.h" from strcasestr.c

  * Use original commit message from Dirk

Dirk, the commit message you sent with version 1 of the patch was
perfect. When you send followup patches, please leave a good commit
message as the initial content of the email. Then add any explanatory
text, ("v.3 of this patch...", "Please test..."), in the email *after*
the "---" separator (just before the diffstat). That way it won't become
part of the commit message and our indelible history.

For now, I manually touched things up, but it would be nice to not have
to do that in the future.

Thanks!

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLxgxm6JDdNq8qSWgRApPxAKCEB4AN8ykZ/n3ERkhPnd6Pf3i4ogCfSGXF
FdxsBSuiHfzeTWbS651dLvI=
=uo4t
-----END PGP SIGNATURE-----
--=-=-=--