Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1AA1C429E45 for ; Tue, 25 Feb 2014 11:31:05 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pkX8v1Jz5jX0 for ; Tue, 25 Feb 2014 11:30:57 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id B7FBD429E43 for ; Tue, 25 Feb 2014 11:30:57 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 2F46F100064; Tue, 25 Feb 2014 21:30:47 +0200 (EET) From: Tomi Ollila To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH] test: Simplify CLEAN list construction In-Reply-To: <1393355939-14431-1-git-send-email-amdragon@mit.edu> References: <1393355939-14431-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.17+108~gb327c11 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2014 19:31:05 -0000 On Tue, Feb 25 2014, Austin Clements wrote: > Construct as much of the CLEAN list from TEST_BINARIES as possible, > rather than duplicating this information by hand. > --- LGTM. database-test.c is a "library" Tomi > test/Makefile.local | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/test/Makefile.local b/test/Makefile.local > index 8870ca3..99324ba 100644 > --- a/test/Makefile.local > +++ b/test/Makefile.local > @@ -50,11 +50,6 @@ test: all test-binaries > check: test > > SRCS := $(SRCS) $(smtp_dummy_srcs) > -CLEAN := $(CLEAN) $(dir)/smtp-dummy $(dir)/smtp-dummy.o \ > - $(dir)/symbol-test $(dir)/symbol-test.o \ > - $(dir)/arg-test $(dir)/arg-test.o \ > - $(dir)/hex-xcode $(dir)/hex-xcode.o \ > +CLEAN += $(TEST_BINARIES) $(addsuffix .o,$(TEST_BINARIES)) \ > $(dir)/database-test.o \ > - $(dir)/random-corpus $(dir)/random-corpus.o \ > - $(dir)/parse-time $(dir)/parse-time.o \ > $(dir)/corpus.mail $(dir)/test-results $(dir)/tmp.* > -- > 1.8.4.rc3 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch