From: Carl Worth <cworth@cworth.org>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: patches for 0.4
In-Reply-To: <1274252620-1249-1-git-send-email-dme@dme.org>
References: <1274252620-1249-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.3.1-22-g1d528f8 (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Thu, 03 Jun 2010 19:20:54 -0700
Message-ID: <87r5knczcp.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, 19 May 2010 08:03:27 +0100, David Edmondson <dme@dme.org> wrote:
> This is a set of small feature and cleanup patches. The only
> particularly significant one is patch 2, as it fixes a memory
> corruption bug in notmuch.

Thanks, David.

Most of these I had already picked up in my recent scan of my
queue. Specifically:

> [PATCH 01/13] emacs: Usability improvements for `notmuch-hello'.
> [PATCH 02/13] notmuch: Fix off-by-one errors if a header is >200 characte=
rs long.
> [PATCH 04/13] emacs: Display non-matching authors with a different face.
> [PATCH 05/13] emacs: Set the `face' property rather than `font-lock-face'.
> [PATCH 06/13] emacs: Allow control over faces for search mode columns.
> [PATCH 07/13] emacs: Allow tuning of the tag/saved search layout.
> [PATCH 08/13] emacs: Reuse rather than reinvent message header filtering
> [PATCH 11/13] emacs: Pretty print the numbers of matching messages.
> [PATCH 13/13] emacs: Allow the display of absolute dates in the header li=
ne.

I did find three new patches here, which I've now committed:

> [PATCH 03/13] emacs: Adjust comment to avoid confusing font-lock.
> [PATCH 10/13] emacs: In search mode, truncate authors using invisible tex=
t.
> [PATCH 12/13] emacs: Tags should be shown with `notmuch-tag-face'.

Finally, there is this one patch in the series that I have tagged for a
closer review:

> [PATCH 09/13] emacs: Avoid runtime use of `cl'.

Perhaps it's just fine now that you've been testing it a while, but at
least in your original email you said you wanted some additional review,
so I planned to do that.

Thanks for sending this list, (and for all of your work on these
features!).

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMCGMG6JDdNq8qSWgRAp1jAJ45IWRWcpiQKOciTad9pzNgtAmFKgCeJYDz
l1WVv0gSRggWmU9O4khjORI=
=XWuL
-----END PGP SIGNATURE-----
--=-=-=--