From: David Bremner <david@tethera.net>
To: Amadeusz =?utf-8?B?xbtvxYJub3dza2k=?= <aidecoe@aidecoe.name>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] Build symbol-test with make instead of hardcoding in
	symbol-hiding.
In-Reply-To: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>
References: <1322218492-8300-1-git-send-email-aidecoe@aidecoe.name>
User-Agent: Notmuch/0.10~rc1+12~g53b921d (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 25 Nov 2011 09:04:44 -0400
Message-ID: <878vn4bbf7.fsf@convex-new.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Fri, 25 Nov 2011 11:54:51 +0100, Amadeusz =C5=BBo=C5=82nowski <aidecoe@a=
idecoe.name> wrote:
>=20=20
> +$(dir)/symbol-test: $(dir)/symbol-test.o
> +	$(call quiet,CC) $^ -o $@ -Llib -lnotmuch -lxapian

I'm a bit surprised no -I is neaded here. Is that taken care in the CC call?

>  .PHONY: test check
> -test:	all $(dir)/smtp-dummy
> +test:	all $(dir)/smtp-dummy $(dir)/symbol-test
>  	@${dir}/notmuch-test $(OPTIONS)

The instructions were already wrong, but maybe they should be updated to
point out that calling the test scripts directly requires smtp-dummy and
symbol-test already be built. Or maybe the tests should check for these
binaries as pre-reqs along with emacs, gpg, etc...=20

> +	   -e "/^(emacs.expected-output|smtp-dummy|smtp-dummy.c|test-verbose|sy=
mbol-test.cc|symbol-test|symbol-test.o)/d" \

I wonder if this should be shortened (and made a bit sloppier) with the
use of regexes.