DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:subject
	:in-reply-to:references:date:message-id:mime-version:
	content-type; q=dns; s=sspaeth.de; b=azxpWIOOqew6ig0ZRQcbHq2ibkT
	nkPPSjNGf9ReSwuPEvJNMbQAp9s9qVNpjX9sFMwCDR14vorXl84pczQOKEqPhPTH
	g+tTDyGRkA7Y8nLlK2tRUpkU6SALofqYuEnFXMf/2LzVpxEsndDvi3FgdysHhj9I
	Qd9ln6hP2de6fvIs=
From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: David Bremner <david@tethera.net>, Anton Khirnov <anton@khirnov.net>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] python/thread: always return a string in
	get_subject/authors
In-Reply-To: <87bozcvzdy.fsf@zancas.localnet>
References: <1304924794-20380-1-git-send-email-anton@khirnov.net>
	<87bozcvzdy.fsf@zancas.localnet>
User-Agent: Notmuch/0.5-164-g8ce82ed (http://notmuchmail.org) Emacs/23.1.50.1
	(x86_64-pc-linux-gnu)
Date: Tue, 10 May 2011 03:00:44 +0200
Message-ID: <87zkmv5pz6.fsf@SSpaeth.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 09 May 2011 09:20:41 -0300, David Bremner <david@tethera.net> wrote:
> On Mon,  9 May 2011 09:06:34 +0200, Anton Khirnov <anton@khirnov.net> wro=
te:
> > Now None is returned when those don't exist, which is inconvenient to
> > deal with.
>=20
> I'm not using the python bindings, but from a philosophical point of
> view, this change makes me a bit uncomfortable since it apparently
> merges two cases together, and makes an error (no Subject)
> indistinguishable from an odd situation (Subject of empty string).
> Or am I missing something here?

Hi there,

This change makes me a bit uncomfortable too. 3 Reasons:

=2D I believe users should be able to distinguish the case when someone
  uses an empty subject, and when someone doesn't specify a subject at
  all.

=2D People have been writing code and breaking backwards compatability for
  such a small gain doesn't really seem worth it.

=2D Testing-wise this is easy. Just test for "if subject:" on the returned
  value and you'll get both cases (empty and non-existing).

But if people really want it, I won't object.

Sebastian

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk3Ijj0ACgkQVYX1jMgnoGK9KACfWcOpLx/BBx6ag1dkf7KGN5yX
PyAAn0kBkL6eqFKegSJprr7HE+GiSLeW
=+jUo
-----END PGP SIGNATURE-----
--=-=-=--