Return-Path: <polatel@gmail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 0B1D2431FC7
	for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:46:37 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.799
X-Spam-Level: 
X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id HSDXYcFTx-DV for <notmuch@notmuchmail.org>;
	Tue, 21 May 2013 07:46:32 -0700 (PDT)
Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com
	[209.85.215.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 8D356431FB6
	for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:46:32 -0700 (PDT)
Received: by mail-ea0-f175.google.com with SMTP id h10so453655eaj.34
	for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:46:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=date:from:to:cc:subject:message-id:mail-followup-to:references
	:mime-version:content-type:content-disposition:in-reply-to
	:organization:user-agent;
	bh=C2zmDtZNk03NQZ3kPsSnKubxEICY+i8qBo1CYeOzhOo=;
	b=TpEMwmONavMAvCuqNROvLDocQc7/1Cv8qBov7xD1iEkXyLsqCvlSEbpkOg2qE79Bl4
	c0jisNfmQseGphuB9nfFY9kayhQnwVLsR7dhL8yuPpGpeQB2eqRX/kz7iazqtnE7Om7e
	jKR9NbALMbPqrNUHXhBclCstK2/mUArulmzBqba0D1sCXMqFGVu25w8/y1Hbrp4Prckl
	Ev8kxknx7H+OWGmCHIhLKJGaAjaX8dNGue8vke7rbROZ8DL0o3qXITRmbZOotvvzlM0X
	El3LtHFpyO6jnuXJTXGihEzw+vHqbrTTJ5WdqHVk7kONwVJDWgq96PLjteUBPqBIvlor
	IwUw==
X-Received: by 10.15.22.135 with SMTP id f7mr7233454eeu.29.1369147591340;
	Tue, 21 May 2013 07:46:31 -0700 (PDT)
Received: from localhost ([88.234.58.113])
	by mx.google.com with ESMTPSA id x41sm3965936eey.17.2013.05.21.07.46.29
	for <multiple recipients>
	(version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
	Tue, 21 May 2013 07:46:30 -0700 (PDT)
Date: Tue, 21 May 2013 17:46:59 +0300
From: Ali Polatel <polatel@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()
Message-ID: <20130521144659.GA6002@hayalet>
Mail-Followup-To: Tomi Ollila <tomi.ollila@iki.fi>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	notmuch@notmuchmail.org
References: <1369052664-17869-1-git-send-email-felipe.contreras@gmail.com>
	<1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>
	<m2vc6c4dtq.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT"
Content-Disposition: inline
In-Reply-To: <m2vc6c4dtq.fsf@guru.guru-group.fi>
Organization: Pink Floyd
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 21 May 2013 14:46:37 -0000


--X1bOJ3K7DJ5YkBrT
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline

2013/05/21 Tomi Ollila <tomi.ollila@iki.fi>:
>On Mon, May 20 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>
>> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are
>> loaded lazily, so nobody would notice unless they try
>> 'query::count_messages'.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
>This patch could be pushed on it's own, but someone (like Ali) could
>comment on the change as searches on both UINT2FIX() & UINT2NUM()
>provides (IMH) insatisfactory results...

LGTM.

My bad, there's no such thing as UINT2FIX().
Yet, what's wrong with UINT2NUM()?

The description looks like:
"...take an unsigned int and convert it to a FIXNUM object if it will fit;
otherwise, convert to a Bignum object..."

Besides ruby-1.8 has it and that's the oldest version I was willing to
support. (If you have some free time, please confirm this because I may
not be remembering correctly.)

>Tomi

		-alip

>
>> ---
>>  bindings/ruby/query.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bindings/ruby/query.c b/bindings/ruby/query.c
>> index e5ba1b7..1658ede 100644
>> --- a/bindings/ruby/query.c
>> +++ b/bindings/ruby/query.c
>> @@ -180,5 +180,5 @@ notmuch_rb_query_count_messages (VALUE self)
>>       * (function may return 0 after printing a message)
>>       * Thus there is nothing we can do here...
>>       */
>> -    return UINT2FIX(notmuch_query_count_messages(query));
>> +    return UINT2NUM(notmuch_query_count_messages(query));
>>  }
>> --
>> 1.8.3.rc3.286.g3d43083
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch

--X1bOJ3K7DJ5YkBrT
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iEYEARECAAYFAlGbiOAACgkQQU4yORhF8iBBGACdEaM899S+FCDWzTKnT4rEUsho
yHsAn1kzSlkWOacI25lREHn+q6boc6el
=FME9
-----END PGP SIGNATURE-----

--X1bOJ3K7DJ5YkBrT--