Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E71B0431FAF for ; Thu, 19 Jan 2012 16:35:23 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o0u10sW6tcvz for ; Thu, 19 Jan 2012 16:35:23 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4470E431FAE for ; Thu, 19 Jan 2012 16:35:23 -0800 (PST) Received: by wibhr12 with SMTP id hr12so24342wib.26 for ; Thu, 19 Jan 2012 16:35:22 -0800 (PST) Received: by 10.180.73.72 with SMTP id j8mr37502940wiv.2.1327019722081; Thu, 19 Jan 2012 16:35:22 -0800 (PST) Received: from localhost ([109.131.97.13]) by mx.google.com with ESMTPS id g12sm3314744wiw.10.2012.01.19.16.35.21 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 19 Jan 2012 16:35:21 -0800 (PST) From: Pieter Praet To: Tomi Ollila , Dmitry Kurochkin , Ethan Glasser-Camp Subject: Re: [PATCH] test: always report missing prereqs, independent of `--verbose' option In-Reply-To: <87d3afuspp.fsf@praet.org> References: <87d3aj8rcl.fsf@gmail.com> <1326889181-32311-1-git-send-email-pieter@praet.org> <87d3afuspp.fsf@praet.org> User-Agent: Notmuch/0.11+99~gab86e73 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Fri, 20 Jan 2012 01:33:31 +0100 Message-ID: <87aa5jus9w.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 00:35:24 -0000 On Fri, 20 Jan 2012 01:24:02 +0100, Pieter Praet wrote: > [...] > Most likely because "$test_subtest_missing_external_prereqs_" is only > reset at the beginning of every test series, so if an Emacs-dependent > subtest is skipped, all subsequent skipped subtests will report that > dependency as well, even if they were skipped due to a missing vi :). > [...] That's not right at all. "$test_subtest_missing_external_prereqs_" is reset at every invocation of `test_begin_subtest', using `test_reset_state_'. Apologies for the misinformation. Peace -- Pieter