Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0E405429E27 for ; Thu, 17 Nov 2011 03:08:20 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xjxvcMUCj6W4 for ; Thu, 17 Nov 2011 03:08:19 -0800 (PST) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 42A71431FD0 for ; Thu, 17 Nov 2011 03:08:19 -0800 (PST) Received: by bkaq10 with SMTP id q10so1970611bka.26 for ; Thu, 17 Nov 2011 03:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=VrmdKh1n6f+Jn0CIHiyDuL/jzAdCV4VGW+k4pfXcymg=; b=UEC4KZ/LcU+m8BTTem7cYhKCmjCCmvGl3NEl3i3Fw0omGThbWrXG7EJkZ4yfaX6xTX 3lgiXqOP0IDRxlu2ZHYlettdzVp1ZcGbwznlPzpm+OP5+iMx2lYrnljWXq/hGl+KRRbg GDwLZL4BT1hFdflvHFWthNdp7Iet1Fd36hwf4= Received: by 10.204.130.65 with SMTP id r1mr33162947bks.27.1321528096444; Thu, 17 Nov 2011 03:08:16 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id n19sm9142080bka.0.2011.11.17.03.08.14 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 17 Nov 2011 03:08:15 -0800 (PST) From: Dmitry Kurochkin To: Jameson Graef Rollins , notmuch@notmuchmail.org Subject: Re: [PATCH 2/9] test: set EMACS_SERVER variable only after dtach(1) was successfully started In-Reply-To: <8739dn6rh6.fsf@servo.finestructure.net> References: <1321494986-18998-1-git-send-email-dmitry.kurochkin@gmail.com> <1321494986-18998-3-git-send-email-dmitry.kurochkin@gmail.com> <8739dn6rh6.fsf@servo.finestructure.net> User-Agent: Notmuch/0.10_rc1+9~g8270095 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Thu, 17 Nov 2011 15:07:59 +0400 Message-ID: <87mxbvnh0w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2011 11:08:20 -0000 On Thu, 17 Nov 2011 01:14:13 -0800, Jameson Graef Rollins wrote: > On Thu, 17 Nov 2011 05:56:19 +0400, Dmitry Kurochkin wrote: > > Otherwise, we can set the EMACS_SERVER and return with an error. And > > subsequent calls to test_emacs would assume that emacs server is running. > > Hey, Dmitry. Can you explain this a bit more? I'm not sure I > understand the case this is protecting against. > We are protectint from the case when dtach is not installed. Then we would return from the test_emacs function with an error "dtach ... || return". EMACS_SERVER should not be set in this case. Regards, Dmitry > jamie.