Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2B335431FAF for ; Fri, 20 Jan 2012 12:20:27 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4NfBW6ZYwaCM for ; Fri, 20 Jan 2012 12:20:26 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 97A81431FAE for ; Fri, 20 Jan 2012 12:20:26 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 331CD66E0012; Fri, 20 Jan 2012 12:20:26 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (m17.ligo.caltech.edu [131.215.115.117]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 71B8466E0124; Fri, 20 Jan 2012 12:20:23 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 490112EA; Fri, 20 Jan 2012 12:20:23 -0800 (PST) From: Jameson Graef Rollins To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 2/3] emacs: Don't return the button from `notmuch-show-insert-part-header'. In-Reply-To: <1327052612-1040-2-git-send-email-dme@dme.org> References: <1327052612-1040-1-git-send-email-dme@dme.org> <1327052612-1040-2-git-send-email-dme@dme.org> User-Agent: Notmuch/0.11+92~g9b8f34f (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 20 Jan 2012 12:20:20 -0800 Message-ID: <87zkdiktx7.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 20:20:27 -0000 --=-=-= On Fri, 20 Jan 2012 09:43:31 +0000, David Edmondson wrote: > The buttons inserted for encrypted parts are slightly different now - > previously the logic was that if a part was encrypted it would have > the signature status inserted only if the encryption status was > specified. Now the signature status will be inserted even without > encryption status. My reading of the documentation says that this is > correct, but I'm no expert. Comments? I need some more time to review this patch, but I don't think this is correct. The signature status of encrypted messages (or even if the message was signed at all) comes from the decryption process. They're not independent. If the decryption fails it's unknown if there was a signature or not. I need to look closer at this, though. Hopefully this weekend. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPGcyEAAoJEO00zqvie6q8makP/1oBgbpfEWTPR1nAGoGA8I6P EzEBnIpf6gmrMc4evwTG4toJAMsiSqcJTvMny/3yqYK4sNP7fbGefxDh/BG1zaPm OMfVp2xkqelubiAgmma+s0WT0hSUdhqZMrV4HX22RHJTcgz/MSGC+ZeAQv4wajh0 iCyCdjFHsG3SirJa7OEZR+IqcZKvmEEgJLpAPW3/1q/gBwBBIWoWIu04z60vkMGa byFBiiipYvLqE0I0ssmWCMkssgsOoZMSMd8NGOJJOOKcX/yZyeiDv9aey7dM6qQZ ziWnJmfO2ApK0r47jWWvaes6CRQUeEEal+79uIonAaZcJR/CGOeG1Fu6Qg75TVbP nK7CxZxHM4AsGsmBJbKFDN0NnQhhOuyfdSBCWsd+oOWyJfKa/lKmMomywIAt7MFw rwV5u825T5aeH463hiEBSKbqNiHTjCBW0F964/JiqGUiJsMrSnptfyidEIjEHGet i2WwDcacg7mmDq44ES9XC90zseQ9wRpCjofqmlfs1KmTJrYFdxHuHYcrUjZVg5vN no74/wPpF2EfFqW2ocIRxo9QbnaFs/HgYu1pzalQ+p9MryfIctWYGFcPsPpvZE5U v6+1oUpBGLXu0e+NxSoQSR9uvuVVMj23iMuGb1p22PVbS2VI44i/UuKYkXIWKRjQ +0bzkYuojSQwrf3zgWiI =n7oz -----END PGP SIGNATURE----- --=-=-=--