Return-Path: <jani@nikula.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 2D901431FD7
	for <notmuch@notmuchmail.org>; Sat,  6 Dec 2014 01:47:27 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id zbwp-5cPa1pW for <notmuch@notmuchmail.org>;
	Sat,  6 Dec 2014 01:47:22 -0800 (PST)
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com
 [74.125.82.44])	(using TLSv1 with cipher RC4-SHA (128/128 bits))	(No client
 certificate requested)	by olra.theworths.org (Postfix) with ESMTPS id
 A80C7431FBC	for <notmuch@notmuchmail.org>; Sat,  6 Dec 2014 01:47:22 -0800
 (PST)
Received: by mail-wg0-f44.google.com with SMTP id b13so2722921wgh.3
	for <notmuch@notmuchmail.org>; Sat, 06 Dec 2014 01:47:21 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:from:to:subject:in-reply-to:references
	:user-agent:date:message-id:mime-version:content-type;
	bh=pGqWmenQqYjJVytphSfToMws6GK55t5VnK1CXX+cPeI=;
	b=W2CHABUupM5+nNuVHlz+9DroCWida+HIVjAxVNuUJumFBuRE3ytqkYnhxDkCcnq1hv
	ML6xhDXQmeM0PxhauS8n/SIiJxADQcIn4JavQoK5l+CBugY+DWbg0lMpLsc5vqoW57F0
	qXJq0McdNEI/JWQG6HqSu1Zaa9HuhTHf/Qu4Sp8BaJ1ztLaHhve6k9+EqeGwYNfSb7EC
	FfDAcSAdd9bhsyKiXEgctOQgIc7sESlpUQ3dEHIFaXtOudVxTZCPawfIqaE6S2T20W1h
	5i2wFFiY5+A7UXg/PexGbeK7AgF8oXovTT3DFGYOfx6HqmQRmU1DcdDkWkK/UDixV+be
	dW5w==
X-Gm-Message-State:
 ALoCoQnZai4ybqh9pFoZlWXY86+qGrOz3euPi0N58XjqQJuIghrWqP0AW1gDvcRvC4rYhonCvLSM
X-Received: by 10.180.103.162 with SMTP id fx2mr10251960wib.42.1417859241369; 
	Sat, 06 Dec 2014 01:47:21 -0800 (PST)
Received: from localhost (mobile-internet-bceeb5-193.dhcp.inet.fi.
	[188.238.181.193])
	by mx.google.com with ESMTPSA id j1sm48073392wjw.25.2014.12.06.01.47.20
	for <multiple recipients>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Sat, 06 Dec 2014 01:47:20 -0800 (PST)
From: Jani Nikula <jani@nikula.org>
To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/2] Use email address instead of empty real name.
In-Reply-To: <1416662236-26556-1-git-send-email-jrosenthal@jhu.edu>
References: <1416662236-26556-1-git-send-email-jrosenthal@jhu.edu>
User-Agent: Notmuch/0.19+3~g7585e8c (http://notmuchmail.org) Emacs/24.4.1
	(x86_64-pc-linux-gnu)
Date: Sat, 06 Dec 2014 11:47:23 +0200
Message-ID: <87k325ds9g.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Dec 2014 09:47:27 -0000

On Sat, 22 Nov 2014, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> This version obsoletes [1].
>
> The changes in this version are:
>
>   * Commit test first with known-broken annotation, and then remove
>     that annotation in the second commit (when the test passes)
>
>   * Style fixes in the thread.cc to conform with notmuch style.

LGTM.

>
> [1] id:1416585462-24558-1-git-send-email-jrosenthal@jhu.edu
>
> Jesse Rosenthal (2):
>   test: Add known-broken test for empty author name
>   lib: Use email address instead of empty real name.
>
>  lib/thread.cc              |  3 ++-
>  test/T205-author-naming.sh | 12 ++++++++++++
>  2 files changed, 14 insertions(+), 1 deletion(-)
>  create mode 100755 test/T205-author-naming.sh
>
> -- 
> 2.1.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch