Date: Fri, 22 Jul 2011 20:13:16 +0100
From: Patrick Totzke <patricktotzke@googlemail.com>
To: Michael Heinrich <michael@haas-heinrich.de>
Subject: Re: [Patch] tag.py: Bugfix to avoid decode() on a NoneType object
Message-ID: <20110722191316.GA12929@brick.lan>
References: <loom.20110722T160702-94@post.gmane.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="sm4nu43k4a2Rpi4c"
Content-Disposition: inline
In-Reply-To: <loom.20110722T160702-94@post.gmane.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list


--sm4nu43k4a2Rpi4c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Michael,

I also fell over this a while ago. (cf. http://notmuch.198994.n3.nabble.com=
/Encodings-td3159281.html)
Your patch certainly fix the immediate error, but there is ore to the probl=
em:
Tagstrings seem to be the only ones stored by notmuch as-is, so unlike
headers, they don't get converted to utf-8. The patch that lead to
this .decode('utf-8') was pushed a bit too hastily.
As Uwe mentiones in above cited thread, we could consider enforcing
tags to be utf-8..

best,
/p


On Fri, Jul 22, 2011 at 02:11:41PM +0000, Michael Heinrich wrote:
> Dear all,
>=20
> with current head I get following error in my python scripts when I read =
the
> tags of a message:
>=20
>   File "/home/heinrich/.local/lib/python2.6/site-packages/notmuch/tag.py"=
, line
> 88, in next
>     tag =3D Tags._get(self._tags).decode('utf-8')
>=20
>=20
> Here is a patch:
>=20
> diff --git a/bindings/python/notmuch/tag.py b/bindings/python/notmuch/tag=
=2Epy
> index 65a9118..e9049fc 100644
> --- a/bindings/python/notmuch/tag.py
> +++ b/bindings/python/notmuch/tag.py
> @@ -85,10 +85,12 @@ class Tags(object):
>              raise NotmuchError(STATUS.NOT_INITIALIZED)
>          # No need to call nmlib.notmuch_tags_valid(self._tags);
>          # Tags._get safely returns None, if there is no more valid tag.
> -        tag =3D Tags._get(self._tags).decode('utf-8')
> +        tag =3D Tags._get(self._tags)
>          if tag is None:
>              self._tags =3D None
>              raise StopIteration
> +        else:
> +            tag =3D tag.decode('utf-8')
>          nmlib.notmuch_tags_move_to_next(self._tags)
>          return tag
> =20
>=20
> Michael.
>=20
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

--sm4nu43k4a2Rpi4c
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4py8wACgkQlDQDZ9fWxapwGwCfbczyKodcgJWrPsN6u6Chd4Y0
Q10AnR3VtSP3M2d9Gj75/0v00R2PgX/s
=Qv7u
-----END PGP SIGNATURE-----

--sm4nu43k4a2Rpi4c--