From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [Patch v5 4/8] lib: add "verbose" versions of
	notmuch_database_{open,create}
In-Reply-To: <m2bnjhuj43.fsf@guru.guru-group.fi>
References: <1426352554-4383-10-git-send-email-david@tethera.net>
	<1427203451-1540-1-git-send-email-david@tethera.net>
	<1427203451-1540-5-git-send-email-david@tethera.net>
	<m2bnjhuj43.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.19+86~gbed8b67 (http://notmuchmail.org) Emacs/24.4.1
	(x86_64-pc-linux-gnu)
Date: Wed, 25 Mar 2015 12:47:06 -0400
Message-ID: <87a8z1owhh.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

Tomi Ollila <tomi.ollila@iki.fi> writes:

>> +    ret = notmuch_database_open_verbose (path,
>> +					 NOTMUCH_DATABASE_MODE_READ_WRITE,
>> +					 &notmuch,
>> +					 &message);
>>      if (ret) {
>> +	if (status_cb) status_cb (message, closure);
>>  	goto DONE;
>>      }
>
> Is this ever printing the message (if any?)

Printing messages is the whole point of status_cb. It does switch the
output from the current stderr to stdout, which is weird.  On the other
hand it avoids changing the api by adding
notmuch_database_compact_verbose.

And of course if we care this should free message after calling
status_cb, like the other places.

d