From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Edmondson <dme@dme.org>, Jani Nikula <jani@nikula.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v3] emacs: add stash support for git send-email
	command	line
In-Reply-To: <cunh9w9gigs.fsf@gargravarr.hh.sledj.net>
References: <cuna921smnf.fsf@gargravarr.hh.sledj.net>
	<1420220897-6245-1-git-send-email-jani@nikula.org>
	<cunh9w9gigs.fsf@gargravarr.hh.sledj.net>
User-Agent: Notmuch/0.19+6~g8725b09 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Fri, 02 Jan 2015 21:54:04 +0200
Message-ID: <m2387t2c2r.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Fri, Jan 02 2015, David Edmondson <dme@dme.org> wrote:

> Looks good to me.


LGTM, too, and seems to work -- and docstrings actually adhere the
conventions...

from http://web.mit.edu/Emacs/source/emacs/lisp/emacs-lisp/checkdoc.el

     ;; * Format the documentation string so that it fits in an
     ;;   Emacs window on an 80-column screen.  It is a good idea
     ;;   for most lines to be no wider than 60 characters.  The
     ;;   first line can be wider if necessary to fit the
     ;;   information that ought to be there.

Tomi

> On Fri, Jan 02 2015, Jani Nikula wrote:
>> Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as
>> --in-reply-to, suitable for pasting to git send-email command line.
>> ---
>>  emacs/notmuch-show.el | 38 ++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 38 insertions(+)
>>
>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
>> index b8cfbb8a3286..9f6fe077df0c 100644
>> --- a/emacs/notmuch-show.el
>> +++ b/emacs/notmuch-show.el
>> @@ -1280,6 +1280,7 @@ reset based on the original query."
>>      (define-key map "t" 'notmuch-show-stash-to)
>>      (define-key map "l" 'notmuch-show-stash-mlarchive-link)
>>      (define-key map "L" 'notmuch-show-stash-mlarchive-link-and-go)
>> +    (define-key map "G" 'notmuch-show-stash-git-send-email)
>>      (define-key map "?" 'notmuch-subkeymap-help)
>>      map)
>>    "Submap for stash commands")
>> @@ -2131,6 +2132,43 @@ the user (see `notmuch-show-stash-mlarchive-link-alist')."
>>    (notmuch-show-stash-mlarchive-link mla)
>>    (browse-url (current-kill 0 t)))
>>  
>> +(defun notmuch-show-stash-git-helper (addresses prefix)
>> +  "Escape, trim, quote, and add PREFIX to each address in list of ADDRESSES, and return the result as a single string."
>> +  (mapconcat (lambda (x)
>> +	       (concat prefix "\""
>> +		       ;; escape double-quotes
>> +		       (replace-regexp-in-string
>> +			"\"" "\\\\\""
>> +			;; trim leading and trailing spaces
>> +			(replace-regexp-in-string
>> +			 "\\(^ *\\| *$\\)" ""
>> +			 x)) "\""))
>> +	     addresses " "))
>> +
>> +(put 'notmuch-show-stash-git-send-email 'notmuch-prefix-doc
>> +     "Copy From/To/Cc of current message to kill-ring in a form suitable for pasting to git send-email command line.")
>> +
>> +(defun notmuch-show-stash-git-send-email (&optional no-in-reply-to)
>> +  "Copy From/To/Cc/Message-Id of current message to kill-ring in a form suitable for pasting to git send-email command line.
>> +
>> +If invoked with a prefix argument (or NO-IN-REPLY-TO is non-nil),
>> +omit --in-reply-to=<Message-Id>."
>> +  (interactive "P")
>> +  (notmuch-common-do-stash
>> +   (mapconcat 'identity
>> +	      (remove ""
>> +		      (list
>> +		       (notmuch-show-stash-git-helper
>> +			(message-tokenize-header (notmuch-show-get-from)) "--to=")
>> +		       (notmuch-show-stash-git-helper
>> +			(message-tokenize-header (notmuch-show-get-to)) "--to=")
>> +		       (notmuch-show-stash-git-helper
>> +			(message-tokenize-header (notmuch-show-get-cc)) "--cc=")
>> +		       (unless no-in-reply-to
>> +			 (notmuch-show-stash-git-helper
>> +			  (list (notmuch-show-get-message-id t)) "--in-reply-to="))))
>> +	      " ")))
>> +
>>  ;; Interactive part functions and their helpers
>>  
>>  (defun notmuch-show-generate-part-buffer (message-id nth)
>> -- 
>> 2.1.4
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch