Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 18C1B431FC3 for ; Tue, 15 Jul 2014 16:29:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kMYN-QCyN6+2 for ; Tue, 15 Jul 2014 16:29:25 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 626F1431FC0 for ; Tue, 15 Jul 2014 16:29:25 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1X7CA0-0003HR-Ol; Tue, 15 Jul 2014 20:29:24 -0300 Received: (nullmailer pid 20872 invoked by uid 1000); Tue, 15 Jul 2014 23:29:21 -0000 From: David Bremner To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: tree/show remove duplicate function In-Reply-To: <87zjgbw0t5.fsf@qmul.ac.uk> References: <1402134668-18587-1-git-send-email-markwalters1009@gmail.com> <87a98bbfab.fsf@maritornes.cs.unb.ca> <87zjgbw0t5.fsf@qmul.ac.uk> User-Agent: Notmuch/0.18.1+39~g64ba418 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Tue, 15 Jul 2014 20:29:21 -0300 Message-ID: <87d2d69p66.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jul 2014 23:29:32 -0000 Mark Walters writes: > On Tue, 15 Jul 2014, David Bremner wrote: >> Mark Walters writes: >>> + (cond ((eq major-mode 'notmuch-show-mode) >>> + (notmuch-show-get-message-properties)) >>> + ((eq major-mode 'notmuch-tree-mode) >>> + (notmuch-tree-get-message-properties)))) >> >> I see this already existed, but it looks weird to me to have a two test >> cond with no else. Is it intentional to have the code drop through and >> do nothing if neither case matches? It seems like it might be better to >> signal an error. > > I can definitely do that. But as a comparison > notmuch-search-get-result and notmuch-search-find-thread-id "work" in > any buffer in the sense of returning nil but not complaining so perhaps > the current version is more consistent. > It occurs to me that we can fix all 3 places in a followup patch, so I'll push this for now. d