Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AA900429E42 for ; Tue, 3 Jan 2012 12:19:30 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CEjecyv9eO7T for ; Tue, 3 Jan 2012 12:19:30 -0800 (PST) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 22214431FD0 for ; Tue, 3 Jan 2012 12:19:30 -0800 (PST) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1RiApQ-0004uE-05; Tue, 03 Jan 2012 20:19:24 +0000 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1RiApP-0002Qe-Pg; Tue, 03 Jan 2012 20:19:23 +0000 From: Mark Walters To: Tomi Ollila , Tomi Ollila , notmuch@notmuchmail.org Subject: Re: Possible bug in tests with emacs 23.2.1 (debian stable) In-Reply-To: References: User-Agent: Notmuch/0.10+44~gded5e61 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Tue, 03 Jan 2012 20:19:23 +0000 Message-ID: <87d3b01qus.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 94.192.233.223 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 79be8d47e6067633500a62bb3e05e5ac (of first 20000 bytes) X-SpamAssassin-Score: -1.8 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.8 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * 0.5 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2012 20:19:30 -0000 On Tue, 03 Jan 2012 15:07:04 +0200, Tomi Ollila wrote: > I did some more testing; doing > > emacsclient --eval '(defun yes-or-no-p (prompt) t)' --eval '(kill-emacs)' > > Will make emacs 23.2.1 exit also, so IMO this "workaround" could be > used to "fix" the problem. I can confirm that the patch below (using this suggestion) fixes the tests for me on emacs 23.2.1 and, on a different machine with emacs 23.3.1 they work just as before. Best wishes Mark diff --git a/test/test-lib.sh b/test/test-lib.sh index 82767c0..218ce91 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -866,7 +866,7 @@ test_done () { echo - [ -n "$EMACS_SERVER" ] && test_emacs '(kill-emacs)' + [ -n "$EMACS_SERVER" ] && test_emacs '(defun yes-or-no-p (prompt) t) (kill-emacs)' if [ "$test_failure" = "0" ]; then if [ "$test_broken" = "0" ]; then