From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Peter Feigl <craven@gmx.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] rewriting notmuch-search for structured output to make
	other output formats easier
In-Reply-To: <1327180568-30385-1-git-send-email-craven@gmx.net>
References: <1327180568-30385-1-git-send-email-craven@gmx.net>
User-Agent: Notmuch/0.11+92~g9b8f34f (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 21 Jan 2012 15:12:57 -0800
Message-ID: <87k44klkee.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Sat, 21 Jan 2012 22:16:08 +0100, Peter Feigl <craven@gmx.net> wrote:
> The output routines have been rewritten so that logical structure
> (objects with key/value pairs, arrays, strings and numbers) are
> written instead of ad-hoc printfs. This allows for easier adaptation
> of other output formats, as only the routines that start/end an object
> etc. have to be rewritten. The logic is the same for all formats.
> The default text output is handled differently, special cases are
> inserted at the proper places, as it differs too much from the
> structured output.

Hi, Peter.  Thanks for the contribution.

There are a lot of changes in this patch so I think you need to think
about how you can break this up into multiple smaller and more atomic
patches.  In particular, the addition of the sexp output format needs to
definitely be in a separate patch from the restructuring of the output
formatting.  You also don't mention anywhere in the commit log that
you've added this new output format.  You'll also need to include
documentation and test suite updates.

Thanks.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPG0Z5AAoJEO00zqvie6q8MYwQALN/K1K3fEShbnvVIAoc1bfs
RFiAz215k5bJkupcf8qY50PPKJRpMD4yY1KGsBhd59CdDRsXCylaN14PsZNQ6hxx
4JnpX1HjjfEwIgCTUmWOyg8KKnmIyJx3BTWArqOR6mzfI1oLQnjO+jpFV6NwZRgm
7U/xZadDt0AUcT66qJaZJ6LUJluKsmb7kJORrZL76QL+0lIACERMvtQaUekjdK93
LsigOk0CqBtky6tN8em7SeXKUnE8GYoLPhYp6nVyonOfEba4inXZlvFSF0LilWkL
gT9JeDIYA12CkNOgu3aDxLsHl0Mwd1S1L2wL98YojOQFHf1akL0M3s1aPawPFoXP
OXuTi2jYwANXbTr7nrSV3+pVhBCkichNwBSL9uN1TB788ZyT3pYHYzRBsiM37cfm
/Rsz2V/9ZI7Rb4I+OiWib3CFwBtMiEZ6yNPMoCHkom7jaYuESyVcX+KlGVlTrokN
QUvI/F3lPfGS5kTAQeanhYYNu3En7bNH8VvxRI8Q0l8GP1JvGDo9HlY8unaYQ6a/
LEKHw6+fagPpDIsIXD7gZAKF9GMA4dJNIzxSvaLJIgrOt620gKTTOwuMTrUtteok
87CcwyR+T3QgEwwb+RWrNoh6o1wcQCJWyc82vhxagImBvkkkWdVU8YCm7oTTDkyz
QSSxvJzNdd0gkDYYhMHc
=CcT9
-----END PGP SIGNATURE-----
--=-=-=--