Date: Wed, 21 May 2014 19:13:05 +1000
From: Fraser Tweedale <frase@frase.id.au>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib
Message-ID: <20140521091304.GT62147@bacardi.hollandpark.frase.id.au>
References: <1399753646-3026-1-git-send-email-xico@atelo.org>
	<536e965c9415e_300d7772fc9@nysa.notmuch>
	<m261ldi98h.fsf@guru.guru-group.fi>
	<536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="LZFKeWUZP29EKQNE"
Content-Disposition: inline
In-Reply-To: <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: list


--LZFKeWUZP29EKQNE
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote:
> Tomi Ollila wrote:
> > On Sun, May 11 2014, Felipe Contreras <felipe.contreras@gmail.com> wrot=
e:
> >=20
> > > X=C4=ABc=C3=B2 wrote:
> > >> Since zlib is part of the base system, FreeBSD chose not to register=
 it
> > >> in pkg-config through zlib.pc. As a fallback test, configure will bu=
ild
> > >> and run a zlib version check and make sure the header and library
> > >> versions are compatible.
> > >
> > > We could try to generate our on zlib.pc, this way the configure script
> > > would be cleaner.
> >=20
> > But for that we'd need to figure out the version, and is there simpler
> > robust way to do that some other way ?
>=20
> I don't meant to change the code that is checking for the version in the
> patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.c,
> or something.
>=20

[please cc me in replies; I am not subscribed to the list]

I think that the additional complexity outweighs the benefit of a
somewhat cleaner build script.

If the $vz1, $vz2, et al. are what's bothering you, perhaps we could
push the complexity of version comparison into have_zlib.c and
supply the (string) version number as an argument to the program.
The have_zlib program could do the comparison and exit accordingly,
and plain old "1.2.5.2" can take its place in the configure script
once more.

However, I don't see any problems with the patch as it is; I have
tested it on FreeBSD 10.0 and it works.

Regards,

Fraser

> --=20
> Felipe Contreras

--LZFKeWUZP29EKQNE
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQIcBAEBAgAGBQJTfG4gAAoJEEtTkFJBEeHicyAP/Ar2jAL/Gh6QI4J99sO9uGfJ
Xuxd9OQ2CKPLk0YaOl6lek2pqa9YHGZ86CyRT00JGIdrqHykPEawRbF1hpXLSzQb
aDbLYEnFKCBSk4kfdQX//5BM9ovSIe3krTwyJAKNysfL7iGLLDr6u8V00ExuHTVG
nCagnTaADOth3tl13mP7fYN9Q4Ye9TniVDMOBhSKFzMqzAohHK9dHerFXZGM76yx
hnJqM3Zao9XBo5Ow1Wu1k3snEKb+jCcMPg1zUncmIoYecxqJKIj9X0DMZ+Odwmw/
250bbxu1OS/N6ffaitFnCWVvQLFJER8QvG6iErw3V0xpX9zmdF4H8Ans43T+eldT
WsWGtrIfoqkQuBCYlrNTog9rF8DBnB3vx5VsYaBW0vsoHH1faDz7BHy7w5dRVQuF
GxYPWV2HM38rbbZht42AsM8tI/uDp3nsWs7gd9N9+29pwFcy3kboSl0Wiff749BD
gwkM1D1QJmYpNqolMw0opu4kUeF4t2UJlhO7YQMReNIRNjjeqFjhAWmtWKGDMnwQ
ji4QOfCIzwMtc2LBvEpmEHKUtbfxrixruqVmLS8j2l2pRa8opgp955YQ1VYrVS0v
EIVFKQa3wl4wgiy+cRdOG2bfl74HgxxkYxhC9IJzq1Fbxgs2Zhydll4iSpThBJCu
5dpIBwpgZlzvisG0HObV
=41bM
-----END PGP SIGNATURE-----

--LZFKeWUZP29EKQNE--