From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] A bug in the exclude code
In-Reply-To: <87mx7kndd3.fsf@awakening.csail.mit.edu>
References: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com>
	<87mx7kndd3.fsf@awakening.csail.mit.edu>
User-Agent: Notmuch/0.11.1+299~gc586c0b (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Mux_Client_Request_Session: read from master failed: Broken pipe
Date: Wed, 14 Mar 2012 11:12:32 +0000
Message-ID: <871uovjv1b.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Sender-Host-Address: 94.192.233.223
X-QM-SPAM-Info: Sender has good ham record.  :)
X-QM-Body-MD5: 3d492a7bf2f5f568a7c8bb2f82bf86a9 (of first 20000 bytes)
X-SpamAssassin-Score: -1.8
X-SpamAssassin-SpamBar: -
X-SpamAssassin-Report: The QM spam filters have analysed this message to
	determine if it is
	spam. We require at least 5.0 points to mark a message as spam.
	This message scored -1.8 points.
	Summary of the scoring: 
	* -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
	*      medium trust
	*      [138.37.6.40 listed in list.dnswl.org]
	* 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
	provider *      (markwalters1009[at]gmail.com)
	* -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
	*      domain
	*  0.5 AWL AWL: From: address is in the auto white-list
X-QM-Scan-Virus: ClamAV says the message is clean
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Mar 2012 11:12:35 -0000

On Tue, 13 Mar 2012 22:08:24 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
> On Mon, 12 Mar 2012 11:31:52 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> > There is a bug in the exclude code (found by jrollins in the
> > --with-excluded series) but also present in master.  None of the
> > current tests were finding it so the first patch adds two tests.
> > 
> > The bug (and test failure) do not appear in all configuations: on my
> > main test machine (an oldish debian testing 32bit userspace with a
> > 64bit kernel and xapian 1.2.7) all tests pass. On my laptop (a recent
> > debian testing 64bit userspace and xapian 1.2.8) one of the new tests
> > fails.
> > 
> > The second patch fixes the behaviour for me but I don't see why it
> > should make a difference: searches for A and not B should give the
> > same results as A and not (A and B). It could be a bug in xapian, it
> > could be that I am not allowed to reuse queries as I do (is query1 =
> > query1 and query2 allowed?) or it could be some memory use bug on my
> > part.
> > 
> > Anyway the "fix" is small which should help narrow down the actual
> > cause.
> 
> LGTM.  Even if we don't totally understand the root cause here, this
> change is the right thing to do anyway.
> 
> I think it's fine to go ahead and push this ahead of the other exclude
> updates, though obviously those will need a little rebasing on top of
> this.

Please don't push exactly this one: I will try and send a version with
a better commit message and a test that shows what is failing better
later today. (The functional part will be unchanged.)

Best wishes

Mark