From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Patrick Totzke <patricktotzke@googlemail.com>
Subject: Re: date_relative in notmuch-search
In-Reply-To: <20110715210459.GA12727@brick.lan>
References: <20110714222258.GA11914@brick.lan>
	<87oc0v4jt6.fsf@servo.factory.finestructure.net>
	<20110715210459.GA12727@brick.lan>
User-Agent: Notmuch/0.5-353-gb44d56e (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 18 Jul 2011 12:07:21 -0700
Message-ID: <87y5zv2ys6.fsf@servo.factory.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=

On Fri, 15 Jul 2011 22:04:59 +0100, Patrick Totzke <patricktotzke@googlemail.com> wrote:
> Thanks for the tip with git send-mail.

Hi, Patrick.  You might have noticed my response to Felix a little while
ago.  The git format-patch command outputs an email that is meant to be
sent directly to the list, not as an attachment on another message.  The
git send-email command should actually handle sending the mails
(assuming you have a working sendmail-like MTA on your machine.  I would
recommend using git send-email to send patches to the list.

Try resending these two patches as their own emails.

> I didn't really intend to get this "patch" accepted. It was more that
> I feel bad asking for features all the time and as I'm not so
> comfortable with hacking on the notmuch code I thought I'd ask if one
> could implement it like this.  Anyhow, attached you'll find a patch
> for the test and another for the proposed change. Feel free to discard
> it :)

But this is exactly how features get added!  If you want a feature added
to notmuch, send in a patch for it.  Otherwise you'll have to just wait
until someone else submits a patch to do the same thing, which may or
may not ever happen.  It's a community-run project, developed by those
that use the program (which includes you!).  Since you've already done
the work to figure out what needed to be changed, all you need to do now
is follow the procedure I've outlined to publish the patch to the list,
and eventually, hopefully, Carl will get around to pulling it in to the
notmuch master repo.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJOJIRpAAoJEO00zqvie6q8ovUP/30Eq+Xr/9qspCwDRvr1UriQ
26N4a6P/iu1xJCzMUF0/xfkvOFhBjU/86DvxduPQuQv4y3EeOsclUHTpFNlcyR73
yZArSQZv9m2e+uWgTAozYtaLgu7zJLbOILpCiaLUJyZQERZzTfkbGuy23ezUw94g
2TX8IO+TMH0w1X+uiXhxko/z+ofj6568KKUKzhqu7vucKAy4gnFn9xyld/5T7PAF
Z+CdjIDEkq3fGwvXh+hdojbNc+sMWzOUwGt9WqU0t83XXHyh/Ez4qb4qIBQIMATB
TX6KI3eqY+nEHGdTrh4fsWIHD2l30zAHuZ2w0dLxWWZpeFlloaDzjm7JlU+GDSX6
iN3NoMvOdd5I454Cr3ds3KsgoO6SiN5/Dm73xX79qbODsSkHbl9AyHa1hXeJxqxs
IfZa+4gSPmrpL7b0yLixSAw6IR6CiVEYONA8IASFbravypNh619VQwyp1TnuelQR
lBUfIdtOzcazKHlrX7a7yfFS3QVKEnwv/72thsvjgMk6dM5AHChOHyXrGdiqh8Y2
/llCrcRoSXi/qAN80YPnk+wTJ3kl15rfoDpw614ZLjHPfapd1Wg1qflG9WCY/+/r
I0rvnb4miJzSuo9WdLBrZ4nVp/yxdb5wxmTsh+Frme+EfE1c4UMCf1cy9WwsSwbd
3ssnu7pik6P/jZtU3/to
=8Wq5
-----END PGP SIGNATURE-----
--=-=-=--