From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag
In-Reply-To: <87k3q151fx.fsf@zancas.localnet>
References: <1361399077-7737-1-git-send-email-david@tethera.net>
	<1361399077-7737-2-git-send-email-david@tethera.net>
	<m27gm2ax1k.fsf@guru.guru-group.fi>
	<87k3q151fx.fsf@zancas.localnet>
User-Agent: Notmuch/0.15.2+41~g0ce9bd4 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 21 Feb 2013 14:22:42 +0200
Message-ID: <m2y5ehvotp.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Thu, Feb 21 2013, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>>
>> This patch series looks good to me (as far as I can understand, I did
>> not find the "silly bug" in your previous patch...)
>>
>
> Compare :
>
> +    print $notmuch $A_action.$TAGPREFIX.$pair->{tag}, " -- ",
> +      'id:'.$pair->{id};
>
> vs.
>
> +    print $notmuch $D_action.$TAGPREFIX.$pair->{tag},
> +      'id:'.$pair->{id};

Ah, ok :)

> I obviously did not test that version very well.

IIRC that has happened to some other people, too ;(

>> Instead of mentioning that "calls are _not_ passed to shell" here,
>> that could be briefly mentioned just before system() calls in the
>> script -- and that definitely should not be 'At the moment' feature.
>
> Sure, the "At the moment" is meant to modify "relies". In the next
> patch, we stop relying on this feature of Perl.

Well, one have to expect the execution to happen one way or another
(and arrange quoting accordingly); for example:

$ echo; perl -e 'exec q/echo "foobar"/'

foobar

vs.

$ echo; perl -e 'exec qw/echo "foobar"/'

"foobar"

first gave exec one arg, 'echo "foobar"' and due to "":s perl used sh
to execute it, second gave exec list [ 'echo', '"foobar"' ] and therefore
echo got foobar with quotes as a command line argument.

Anyone interested for more information, see 'perldoc -f exec'.


>> the system() function in perl(1) never pass execution through the
>> shell in case the args are list more than one arg:
>
> right. that's what I meant by "is a documented feature of perl's system
> function"
>
> So I think we mean to say the same thing here; but I could I add a
> comment in this patch (to delete it in the next). Or maybe reword that
> commit message somehow.

Yes, the message is the same, just that there should not be need for that..

> d

Tomi