Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C9E1B431FDE for ; Tue, 24 Jan 2012 08:14:26 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aQfiof+BgVxL for ; Tue, 24 Jan 2012 08:14:25 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 59307431FD9 for ; Tue, 24 Jan 2012 08:14:23 -0800 (PST) Received: by mail-wi0-f181.google.com with SMTP id hi8so1696072wib.26 for ; Tue, 24 Jan 2012 08:14:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.100.228 with SMTP id fb4mr21963953wib.1.1327421662993; Tue, 24 Jan 2012 08:14:22 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id d9sm19544892wiy.2.2012.01.24.08.14.21 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Jan 2012 08:14:22 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 148329FD44; Tue, 24 Jan 2012 16:14:20 +0000 (GMT) From: David Edmondson To: notmuch@notmuchmail.org Subject: [PATCH 1/4 v43] test: Don't return the result of checking for running emacs to the tester. Date: Tue, 24 Jan 2012 16:14:04 +0000 Message-Id: <1327421647-30405-2-git-send-email-dme@dme.org> X-Mailer: git-send-email 1.7.8.3 In-Reply-To: <1327421647-30405-1-git-send-email-dme@dme.org> References: <1326804748-8989-2-git-send-email-dme@dme.org> <1327421647-30405-1-git-send-email-dme@dme.org> X-Gm-Message-State: ALoCoQnimUCYdK7PuO8xjhDBM8/trGWmM9mZ9xbQ+/sYKWpilzojw50bA5L3fSoo6Au1exrsBXYZ X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2012 16:14:27 -0000 When checking for a running emacs, test_emacs evaluates the empty list '()'. This returns 'nil' when emacs is running, which is then prepended to the actual test result. Given that it is not part of the actual test output the test harness can incorrectly report test failure (or success). --- test/test-lib.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 0da60fb..82c686c 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -926,7 +926,7 @@ test_emacs () { --eval '(orphan-watchdog $$)'" || return EMACS_SERVER="$server_name" # wait until the emacs server is up - until test_emacs '()' 2>/dev/null; do + until test_emacs '()' >/dev/null 2>/dev/null; do sleep 1 done fi -- 1.7.8.3