From: Carl Worth <cworth@cworth.org>
To: Tomas Carnecky <tom@dbservice.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] Wrap the compat header in extern "C" { } when compiling
	C++ sources
In-Reply-To: <1272389237-16257-1-git-send-email-tom@dbservice.com>
References: <1272389237-16257-1-git-send-email-tom@dbservice.com>
User-Agent: Notmuch/0.2-251-g8514e59 (http://notmuchmail.org) Emacs/23.1.1
	(i486-pc-linux-gnu)
Date: Tue, 27 Apr 2010 10:43:11 -0700
Message-ID: <87tyqwlrkg.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Tue, 27 Apr 2010 19:27:17 +0200, Tomas Carnecky <tom@dbservice.com> wrote:
> This fixes a build error on OpenSolaris where the final liking of
> notmuch fails because the linker can't find strcasestr() referenced
> from thread.cc.

Thanks for the fix. I've pushed this out, (and just in time for 0.3.1).

> Is it safe to use NOTMUCH_BEGIN/END_DECLS in the compat header? The sha1 header
> also uses ifdef __cplusplus instead of that define..

The compat code doesn't include notmuch.h so doesn't see the definition
of those macros. So what you did here is fine.

For the sha1 code---we basically have kept that unchanged from upstream,
so it also does its own thing here.

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFL1yIv6JDdNq8qSWgRAvC4AJ0dM0G0QsSvhFQxzKqA2qmsZLj6iQCeOE9U
/DPpx7XU+QqW/vCrtICimss=
=E5mb
-----END PGP SIGNATURE-----
--=-=-=--