From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>,
	Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
In-Reply-To: <m262fqc0wv.fsf@guru.guru-group.fi>
References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
	<87r4yfszx9.fsf@servo.finestructure.net>
	<87pqdync64.fsf@gmail.com> <m262fqc0wv.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 01 Feb 2012 14:37:53 +0400
Message-ID: <87k446n8ji.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> 
> There are at least these options here
> 
> 1) go through all ~100 places where test_expect_equal_file is used
>    and fix the call order: quick look tells that the offending uses
>    are in dump-restore, hooks, search-limiting and symbol-hiding.
> 
> 2) enforce "expected" filename has some format *and* fix all current
>    uses of it. Add testbed_error () function which yells loudly ane exits...
> 
> 3) guess which is output and which is expected from args so that 
>    machine helps tester here (for both diff output & copied files)a
> 
> 4) just copy compared files to some directory, those are named as
>    basename of the original -- diff order still inconsistent.
> 
> 
> I'd just go with option 1 and fix new *violations* when stumble upon one.
> 

Option 1 does not solve the problem.  New violations would apper and
need to be fixed again.  I am for option 2.

Regards,
  Dmitry

> Tomi