From: Jameson Graef Rollins <jrollins@finestructure.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] emacs: Don't return the button from
	`notmuch-show-insert-part-header'.
In-Reply-To: <1327052612-1040-2-git-send-email-dme@dme.org>
References: <1327052612-1040-1-git-send-email-dme@dme.org>
	<1327052612-1040-2-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.11+93~gc3dc12a (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 22 Jan 2012 13:38:09 -0800
Message-ID: <877h0jmn9a.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Fri, 20 Jan 2012 09:43:31 +0000, David Edmondson <dme@dme.org> wrote:
> Instead, allow the caller to specify some parameters for the
> button. Rework `notmuch-show-insert-part-multipart/signed' and
> `notmuch-show-insert-part-multipart/encrypted' accordingly, moving
> most of the code into a common
> `notmuch-show-insert-part-multipart/signed-or-encrypted' to reduce
> duplication.

Hi, David.  A couple of issues with this patch:

This patch seems to include multiple distinct changes.  There is a
change to notmuch-show-insert-part-header, but a seemingly unrelated
change to the insertion of signed/encrypted part buttons.  They should
be in separate patches.

I'm also not sure I understand why the proposed changes to the
signed/encrypted button insertion functions are necessary or desired.
Was there a problem with the logic as it was?  What is gained by having
one function filled with special casing to handle two things, rather
than having two distinct functions?

Finally, this patch throws out all the changes from the previous patch,
making the previous patch superfluous.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPHIHCAAoJEO00zqvie6q89gYQAKjyylLyOngLm8k43S6P6Wk/
3q8P3H9bYVGQpTIRvn7I5H9YvqZrU98GlkFRcuI7CrwUuy8ojDMpWqC8QGf6hcWx
uF9rdmaozaVxQMQPeWuEgaDlTBFag/brRs14tq/4osQijO4aLd7H/lZlV4KHxWR5
qr7oJxVQ9uZmBFrgrJuFbD+gWA/DnfeEp79aM+lCeQm9KkpKn0AJwDFe/ayARGUv
EL1uHJDenIK2A9MJuzqw/2Io6G2oMLMkRvQMdzuGWY5D9ZBHYZoBZ26AvzaHxHzt
XRd6SdYcQroWCZo/M93t+s+sgEPmeaqbWoMohotlMJMALiitc+4fB1ldLfrKIIcj
DanOQrXVJlTxedmPVymHhYy1Utc0XIblTOT8ax2QyOop2Mc/QbjPXBNfBXYCxx8f
94vFAwW8OOv8qq7F1DmqKZMnKpa/gyc661P5WlkcT5IDP6PdT72JwQJ645QuKKHk
6JJpM+WlEqIhOaIuLj41aPfie4XuMne/Mrd3UBn4hrB2ZOaOFnk8387KkRYfWVzU
8b5bBtwLUZfZYnbPPHCxfxJddgwEFvyZ90nr3j0JeWr+EgKjYxZKMSTZyv7jzTbN
zslA9mrxxF+5kSlH5KWWyTkIHrWVvpdpJ5+u123abI7CBJ/hY+enDD0xapkHH/lB
cCxYdPWDSzX1134/6hAD
=4NDl
-----END PGP SIGNATURE-----
--=-=-=--