From: David Bremner <david@tethera.net>
To: "W. Trevor King" <wking@tremily.us>
Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section
In-Reply-To: <20140924194413.GC20130@odin.tremily.us>
References: <1411400615-20934-1-git-send-email-amdragon@mit.edu>
	<20140922165954.GI20827@odin.tremily.us>
	<20140922185050.GB7970@csail.mit.edu>
	<20140922190022.GO20827@odin.tremily.us>
	<87iokc28mg.fsf@maritornes.cs.unb.ca>
	<20140924181844.GB20130@odin.tremily.us>
	<87d2ak253z.fsf@maritornes.cs.unb.ca>
	<20140924194413.GC20130@odin.tremily.us>
User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 24 Sep 2014 22:13:31 +0200
Message-ID: <87a95o22vo.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Cc: notmuch@notmuchmail.org
Precedence: list

"W. Trevor King" <wking@tremily.us> writes:

> On Wed, Sep 24, 2014 at 09:25:20PM +0200, David Bremner wrote:
>> I think the fact that you have to close the notmuch database (when
>> not using begin/end atomic) to get a commit is surprising for many
>> people, so it would be nice to make that clearer somehow.
>
> It looks like Xapian is GPLv2+, so we should just be able to
> copy/paste/edit the line I quoted from the Xapian docs.
>
> Cheers,
> Trevor

I think it would be better to write our own, not because of licensing
issues, but because the user of the notmuch API won't know what a xapian
commit is.

d