MIME-Version: 1.0
In-Reply-To: <87lji11leu.fsf@yoom.home.cworth.org>
References: <935ead450911181000w2cddfe95qe9efd5bea9f9209d@mail.gmail.com>
	<20091119164543.25e7afe5@hikari>
	<935ead450911191823s776fda6eyb6f6949ac982bd03@mail.gmail.com>
	<87lji11leu.fsf@yoom.home.cworth.org>
Date: Fri, 20 Nov 2009 07:10:38 -0600
Message-ID: <935ead450911200510ie80d28dv1d82ccbd11803128@mail.gmail.com>
From: Jeffrey Ollie <jeff@ocjtech.us>
To: Carl Worth <cworth@cworth.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: Not Much Mail <notmuch@notmuchmail.org>
Subject: Re: [notmuch] Segfault searching for tags
Precedence: list

On Fri, Nov 20, 2009 at 5:32 AM, Carl Worth <cworth@cworth.org> wrote:
> On Thu, 19 Nov 2009 16:45:43 +0100, Adrian Perez de Castro <aperez@igalia=
.com> wrote:
>> The thing is that in notmuch_message_get_in_reply_to(), line 288, a NULL
>> instance of Xapian::TermIterator is dereferenced. In my particular case,
>> the culpript is a cache file of Claws-Mail, as seen in the following GDB
>> session:
>
> Not quite NULL, (nor is it quite dereferencing---this is nasty C++
> overloading), but yeah, the idea is the same. We need to protect all of
> our "calls" to this overloaded operator to not call it when the iterator
> is equal to the value returned by termlist_end ().
>
> On Thu, 19 Nov 2009 20:23:15 -0600, Jeffrey Ollie <jeff@ocjtech.us> wrote=
:
>> I straced some of the crashes, and the last file that was read before
>> the crash was a malformed message. =C2=A0I've attached one of the messag=
es.
>
> Thanks for the file. I never like to push code that I haven't tested, so
> this was very helpful.
>
> Below is the patch that I just pushed which seems to do the trick.

Ah, excellent!  This does indeed seem to prevent the crash.  Now I
just need to figure out how to get all my mail out of GMail.

--=20
Jeff Ollie