Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1676F431FB6 for ; Fri, 7 Nov 2014 01:21:31 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6iwdQ65qEbAT for ; Fri, 7 Nov 2014 01:21:27 -0800 (PST) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id 75BB9431FAE for ; Fri, 7 Nov 2014 01:21:27 -0800 (PST) Received: from localhost (unknown [192.168.200.7]) by max.feld.cvut.cz (Postfix) with ESMTP id 480D95CD092; Fri, 7 Nov 2014 10:21:24 +0100 (CET) X-Virus-Scanned: IMAP STYX AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, port 10044) with ESMTP id 8VQ1S9AQtDFR; Fri, 7 Nov 2014 10:21:18 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id A12335CD088; Fri, 7 Nov 2014 10:21:18 +0100 (CET) Received: from wsh by steelpick.2x.cz with local (Exim 4.84) (envelope-from ) id 1XmfjK-0008UB-EV; Fri, 07 Nov 2014 10:21:18 +0100 From: Michal Sojka To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] cli: notmuch address option defaults update In-Reply-To: <1415297516-29203-1-git-send-email-tomi.ollila@iki.fi> References: <1415297516-29203-1-git-send-email-tomi.ollila@iki.fi> User-Agent: Notmuch/0.18.2+178~g6e9e8bb (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Fri, 07 Nov 2014 10:21:18 +0100 Message-ID: <87h9ybxt69.fsf@steelpick.2x.cz> MIME-Version: 1.0 Content-Type: text/plain Cc: tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 09:21:31 -0000 On Thu, Nov 06 2014, Tomi Ollila wrote: > When no --output option were given, change default to display senders > only. This is faster and provides useful-enough list of addresses. > > When only --count option is given, display senders (in contrary to not > displaying anything). > > Document how --count affects to "sort order" a bit more accurately. > > Clean up some whitespace in the documentation. > > One test updated to have --output=count without sender nor recipient > output option. > --- > > Some quick updates to the notmuch address interface which I hope will > be considered to be included in 0.19 release. As we are in feature freeze > I hope this gets quick feedback, in any way you desire. > > Tomi > > doc/man1/notmuch-address.rst | 34 ++++++++++++++++++---------------- > notmuch-search.c | 4 ++-- > test/T095-address.sh | 14 +++++++------- > 3 files changed, 27 insertions(+), 25 deletions(-) > > diff --git a/doc/man1/notmuch-address.rst b/doc/man1/notmuch-address.rst > index 359616e0dc5f..034607c434d2 100644 > --- a/doc/man1/notmuch-address.rst > +++ b/doc/man1/notmuch-address.rst > @@ -32,28 +32,28 @@ Supported options for **address** include > ``--output=(sender|recipients|count)`` > > Controls which information appears in the output. This option > - can be given multiple times to combine different outputs. > - Omitting this option is equivalent to > - --output=sender --output=recipients. > + can be given multiple times to combine different outputs. > + Omitting this option is equivalent to --output=sender. The implementation does a bit more. What about: When neither --output=sender nor --output=recipients is given, --output=sender is implied. Otherwise it LGTM. Thanks, -Michal