Return-Path: <bremner@unb.ca>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id E6C3C431FBD
	for <notmuch@notmuchmail.org>; Sun, 12 Aug 2012 12:51:21 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id iCG5or0MC+Ou for <notmuch@notmuchmail.org>;
	Sun, 12 Aug 2012 12:51:21 -0700 (PDT)
Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 9FF8A431FAE
	for <notmuch@notmuchmail.org>; Sun, 12 Aug 2012 12:51:21 -0700 (PDT)
Received: from remotemail by tesseract.cs.unb.ca with local (Exim 4.72)
	(envelope-from <bremner@unb.ca>)
	id 1T0eC0-0004O5-4m; Sun, 12 Aug 2012 16:51:20 -0300
Received: (nullmailer pid 32652 invoked by uid 1000);
	Sun, 12 Aug 2012 19:51:16 -0000
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>,
	Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH] sprinters: bugfix when NULL passed for a string.
In-Reply-To: <87mx25ulgq.fsf@qmul.ac.uk>
References: <1344374501-28185-1-git-send-email-amdragon@mit.edu>
	<1344389313-7886-1-git-send-email-amdragon@mit.edu>
	<87mx25ulgq.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.13.2+76~gac7b542 (http://notmuchmail.org) Emacs/24.1.1
	(x86_64-pc-linux-gnu)
Date: Sun, 12 Aug 2012 21:51:16 +0200
Message-ID: <87d32vc2iz.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Aug 2012 19:51:22 -0000

Mark Walters <markwalters1009@gmail.com> writes:

> The string function in a sprinter may be called with a NULL string
> pointer (eg if a header is absent). This causes a segfault. We fix
> this by checking for a null pointer in the string functions 

pushed, 

d