Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6ED25431FAF for ; Mon, 26 Mar 2012 14:04:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8pP24oP8PnjY for ; Mon, 26 Mar 2012 14:04:18 -0700 (PDT) Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A4201431FAE for ; Mon, 26 Mar 2012 14:04:17 -0700 (PDT) Received: by lahc1 with SMTP id c1so4613102lah.26 for ; Mon, 26 Mar 2012 14:04:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=CE/+Cq47IMYPm/Gmgtd9+KR+F6FE1TZ6GlzmSmn1yxY=; b=XEBRj/ufp+whICzdTr6tiQVMN9GTGxLiu+kBJRRV1C+8KC88LtE7CGe3N+w8IBnbi4 tmPcwoQ/+uxSfiZPbQ9UTKuuC7IDnV2/WRMeWqFjpZ0okZTYSGl7WJLP0wiMQldAEsss 1kGb8eWuy/4agIvtYXtk0s6eukBxvVhUZMKxLNfw+u3zqjfGKJbPnnAP5LTAJTVIVpB2 DbSHx9bmAgCz1VpZLOftz9hWWKn9+rMh8HMAJx9SYFSHSqv5QTGRhakiqwPf/D2DYell AFysQ+YDPzwQV/8MwmZy64AtxBRl7ctDEXnMqj3rpRuTdk8MuuuVgI0Q8HCdBvsAg3Il 8+2w== Received: by 10.112.38.68 with SMTP id e4mr8695822lbk.38.1332795855788; Mon, 26 Mar 2012 14:04:15 -0700 (PDT) Received: from localhost (dsl-hkibrasgw4-fe50f800-253.dhcp.inet.fi. [84.248.80.253]) by mx.google.com with ESMTPS id p9sm23268459lbw.10.2012.03.26.14.04.13 (version=SSLv3 cipher=OTHER); Mon, 26 Mar 2012 14:04:14 -0700 (PDT) From: Jani Nikula To: notmuch@notmuchmail.org Subject: [PATCH v3 0/4] cli: notmuch tag/restore refactoring Date: Tue, 27 Mar 2012 00:04:07 +0300 Message-Id: X-Mailer: git-send-email 1.7.5.4 X-Gm-Message-State: ALoCoQkfwigDEkrFvZHEywTq0xnvRXWZJF03iwoE0AzBre8aVIugHWnsEQJnCyZY9Q3cC6Gpfm61 Cc: tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2012 21:04:18 -0000 v3 of id:"cover.1332702915.git.jani@nikula.org" with the following mostly non-functional changes: - add test for the current tagging behaviour in patch 1, and change the test in patch 2 when the behaviour is changed - handle the no tag changes case in _optimize_tag_query() in patch 2 - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == '-');" assignment - document the tag_query() function a bit in patch 3 - make tag_message() static in patch 4 BR, Jani. Jani Nikula (4): test: add test for both adding and removing a tag at the same time cli: refactor "notmuch tag" data structures for tagging operations cli: refactor "notmuch tag" query tagging into a separate function cli: refactor "notmuch restore" message tagging into a separate function notmuch-restore.c | 148 ++++++++++++++++++++++++--------------------- notmuch-tag.c | 173 ++++++++++++++++++++++++++++------------------------- test/tagging | 8 +++ 3 files changed, 178 insertions(+), 151 deletions(-) -- 1.7.5.4