From: Jani Nikula <jani@nikula.org>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: update insert tests for new maildir synchronization
	rules
In-Reply-To: <1378170613-3584-1-git-send-email-david@tethera.net>
References: <1355952747-27350-4-git-send-email-sojkam1@fel.cvut.cz>
	<1378170613-3584-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.16+39~gf3963b0 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 03 Sep 2013 08:22:18 +0300
Message-ID: <87ob8ao4xh.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain
Cc: David Bremner <bremner@debian.org>
Precedence: list

On Tue, 03 Sep 2013, david@tethera.net wrote:
> From: David Bremner <bremner@debian.org>
>
> As of id:1355952747-27350-4-git-send-email-sojkam1@fel.cvut.cz
> we are more conservative about moving messages from ./new to ./cur.
> This updates the insert tests to match
> ---
>
> Hopefully this makes sense, and is not just papering over a real
> problem that should be fixed.

LGTM. I sent some additional tests on top.

Jani.



>
>  test/insert | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/insert b/test/insert
> index 021edb6..1718120 100755
> --- a/test/insert
> +++ b/test/insert
> @@ -82,7 +82,7 @@ gen_insert_msg
>  notmuch insert --folder=Drafts < "$gen_msg_filename"
>  output=$(notmuch search --output=files folder:Drafts)
>  dirname=$(dirname "$output")
> -test_expect_equal "$dirname" "$MAIL_DIR/Drafts/cur"
> +test_expect_equal "$dirname" "$MAIL_DIR/Drafts/new"
>  
>  test_begin_subtest "Insert message into folder, add/remove tags"
>  gen_insert_msg
> @@ -99,14 +99,14 @@ gen_insert_msg
>  notmuch insert --folder=F --create-folder +folder < "$gen_msg_filename"
>  output=$(notmuch search --output=files folder:F tag:folder)
>  basename=$(basename "$output")
> -test_expect_equal_file "$gen_msg_filename" "$MAIL_DIR/F/cur/${basename}"
> +test_expect_equal_file "$gen_msg_filename" "$MAIL_DIR/F/new/${basename}"
>  
>  test_begin_subtest "Insert message, create subfolder"
>  gen_insert_msg
>  notmuch insert --folder=F/G/H/I/J --create-folder +folder < "$gen_msg_filename"
>  output=$(notmuch search --output=files folder:F/G/H/I/J tag:folder)
>  basename=$(basename "$output")
> -test_expect_equal_file "$gen_msg_filename" "${MAIL_DIR}/F/G/H/I/J/cur/${basename}"
> +test_expect_equal_file "$gen_msg_filename" "${MAIL_DIR}/F/G/H/I/J/new/${basename}"
>  
>  test_begin_subtest "Insert message, create existing subfolder"
>  gen_insert_msg
> -- 
> 1.8.3.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

-- 
Jani