From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, david@tethera.net,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 3/3] test: add broken roundtrip test
In-Reply-To: <87zk6524f0.fsf@qmul.ac.uk>
References: <1344190393-22497-1-git-send-email-david@tethera.net>
	<1344190393-22497-4-git-send-email-david@tethera.net>
	<87zk6524f0.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.13.2+137~ge34ed71 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Wed, 08 Aug 2012 09:33:30 -0700
Message-ID: <87k3x9ibs5.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Cc: David Bremner <bremner@debian.org>
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 08 2012, Mark Walters <markwalters1009@gmail.com> wrote:
>>  test/dump-restore |    9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/test/dump-restore b/test/dump-restore
>> index 439e998..7979ebf 100755
>> --- a/test/dump-restore
>> +++ b/test/dump-restore
>> @@ -82,4 +82,13 @@ test_begin_subtest "dump outfile -- from:cworth"
>>  notmuch dump dump-outfile-dash-inbox.actual -- from:cworth
>>  test_expect_equal_file dump-cworth.expected dump-outfile-dash-inbox.act=
ual
>>=20=20
>> +test_expect_success 'roundtripping random message-ids and tags' \
>> +    'test_subtest_known_broken &&
>> +    ${TEST_DIRECTORY}/random-corpus --config-path=3D${NOTMUCH_CONFIG} &&
>> +    notmuch dump > EXPECTED.$test_count &&
>> +    notmuch tag -random-corpus tag:random-corpus &&
>> +    notmuch restore < EXPECTED.$test_count 2>/dev/null &&
>> +    notmuch dump > OUTPUT.$test_count &&
>> +    test_cmp EXPECTED.$test_count OUTPUT.$test_count 1>/dev/null'
>
> Are the single quotes at the start and end of the main block meant to be
> there? And with them deleted this seems to pass (but there is lots of
> diff if the redirection is removed).  I am not familiar with
> test_expect_success/test_cmp so don't know what to expect.

I don't understand what's going on here either.  This seems like a
strange way to run these tests, as a command string to
test_expect_success.  Why not just run them directly?

I'm also worried about the test output blowing away the users terminal.
I think that should be avoided, even if we expect failures to be rare.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQIpTaAAoJEO00zqvie6q8D/wP/iqcM+7J9Qky+8R80lRob490
larFqaOLdL/veUtXthwOo0ceqefEJ7Sy0FJEsPvDMJiarwE+dsHUL5S5HkRrgzy4
T5/Hqb3HJY8OfuIwNqRKdNrhOLrC2tasP3XqaPqTRAun2igfxdxjjMU/EuWkNDeL
I9KTfH78+bptPg+jdwAnIZ5hnd9SKjmT0CQ9laTYpzFCdB0gFRBhSZ0vIZq7BvV0
c6hytG1IpqCWT+VpRYWGrOybjyZzE/ua3uPBLoSzNmGMV5dQMKF7tYZWe4UX7Fdn
fAgRz5J9ejihDWOzoDLjMVCK7DAPvaJ66Ti2YJFzgM55BsB87rO93ngo8c9Ik1dN
33zoKN5OPsboQ+RlV3VC9tzicbHDk0+fqT/wblsm+wVyTWNSoKK1Rl8yphMSTkBd
VDFcmC7nHrd8oz/uvb+5UP+1FSMBtA5FxJO2VRSVZuyLfZJZAVFr9++Lct3ebxZx
Fj0i40+DujvTWkJYYCS/dv1sQuV+/U19XsYx9MeQ52YVnZHcLegHd/XyvvaH48mB
LkwqVlqQ4W7FZnveqNnzXbXL517YaW9n8UqkdTztRTXeWNuoS8sUn3A3w7o7BM1f
wb90/xb6uP2QOn2DCcM4CiiyuKFE39O8XIDCtVRtQoU0Dfies1Fjc6i+m7MtA/66
8PxH9o2vLTFwm0CWXHZ5
=ubiH
-----END PGP SIGNATURE-----
--=-=-=--