Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 23A2F431FB6 for ; Tue, 23 Sep 2014 06:31:52 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bwAYwOCfxkhE for ; Tue, 23 Sep 2014 06:31:48 -0700 (PDT) X-Greylist: delayed 541 seconds by postgrey-1.32 at olra; Tue, 23 Sep 2014 06:31:48 PDT Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4220F431FAF for ; Tue, 23 Sep 2014 06:31:48 -0700 (PDT) Received: from mail.jade-hamburg.de (unknown [85.183.43.52]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cryptobitch.de (Postfix) with ESMTPSA id 271AB7FDE25 for ; Tue, 23 Sep 2014 15:22:44 +0200 (CEST) Received: by mail.jade-hamburg.de (Postfix, from userid 401) id 9E3A3DF2A3; Tue, 23 Sep 2014 15:22:43 +0200 (CEST) Received: from thinkbox.jade-hamburg.de (cryptobitch.de [88.198.7.68]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: teythoon) by mail.jade-hamburg.de (Postfix) with ESMTPSA id 09EBCDF289; Tue, 23 Sep 2014 15:22:41 +0200 (CEST) Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.84) (envelope-from ) id 1XWQ39-0001iQ-KJ; Tue, 23 Sep 2014 15:22:35 +0200 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: David Bremner , "Thibaut Horel" , notmuch@notmuchmail.org From: Justus Winter <4winter@informatik.uni-hamburg.de> In-Reply-To: <87ha02c1pl.fsf@maritornes.cs.unb.ca> References: <20140811044354.GA18790@spoon.client.fas.harvard.edu> <87ha02c1pl.fsf@maritornes.cs.unb.ca> Message-ID: <20140923132230.4207.73297@thinkbox.jade-hamburg.de> User-Agent: alot/0.3.5 Subject: Re: [PATCH] python: Add binding for notmuch_query_add_tag_exclude Date: Tue, 23 Sep 2014 15:22:30 +0200 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2014 13:31:52 -0000 Quoting David Bremner (2014-09-20 07:15:02) > Thibaut Horel writes: > = > > Implemented as the method `exclude_tag` of the class `Query`. This meth= od takes > > one argument, a string containing the name of the tag to exclude > = > This tag looks pretty trivial. I'll merge it unless I hear some > objections over the weekend. It looks fine indeed, thanks to the both of you. The only tricky thing I remember is the py2/py3 string/unicode thing, for which I seem to have created the _str function, so it should be fine indeed. Justus