Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 9E9774196F2 for ; Tue, 27 Apr 2010 10:18:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q0h8hNxcvArf; Tue, 27 Apr 2010 10:18:30 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 932AB431FC1; Tue, 27 Apr 2010 10:18:30 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 47629568DEB; Tue, 27 Apr 2010 10:18:30 -0700 (PDT) From: Carl Worth To: Sebastian Spaeth , Notmuch developer list Subject: Re: [PATCH] Rename already used counter var i In-Reply-To: <87r5m1lyj5.fsf@yoom.home.cworth.org> References: <87tyqxmdw6.fsf@yoom.home.cworth.org> <1272373045-29268-1-git-send-email-Sebastian@SSpaeth.de> <87r5m1lyj5.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.2-251-g8514e59 (http://notmuchmail.org) Emacs/23.1.1 (i486-pc-linux-gnu) Date: Tue, 27 Apr 2010 10:18:30 -0700 Message-ID: <87zl0olspl.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2010 17:18:32 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable > On Tue, 27 Apr 2010 14:57:25 +0200, Sebastian Spaeth wrote: > For a point release like 0.3.1 I'm going to insist on a test case that > demonstrates each regression being fixed. Does someone know what it > takes to make a mail trigger this bug? I investigated this. The key was that the user had to have no configured "other" email addresses, (or at least fewer than the fixed-length array (2) being iterated over in the outer loop) in order to trigger the infinite-loop bug. I just pushed new test cases to master that pass, and verified that the same test cases cause the code in 0.3 to enter an infinite loop. =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFL1xxm6JDdNq8qSWgRAkRKAJ9iUW2gqQTCbV3oPnOC0JKMvD24rACbBsfC PewaUdt7qVYl8moJ5D2Ghkg= =zHo6 -----END PGP SIGNATURE----- --=-=-=--