From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Jesse Rosenthal <jrosenthal@jhu.edu>,
	Notmuch developer list <notmuch@notmuchmail.org>
Subject: Re: [PATCH] Modularize test suite
In-Reply-To: <87sk6cdbxz.fsf@jhu.edu>
References: <87sk6cdbxz.fsf@jhu.edu>
User-Agent: Notmuch/0.3.1-31-g60b2517 (http://notmuchmail.org) Emacs/23.1.1
	(x86_64-pc-linux-gnu)
Date: Wed, 05 May 2010 09:23:57 +0200
Message-ID: <87bpcustf6.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Fri, 30 Apr 2010, Jesse Rosenthal wrote:
> Responding to this email is a patch to modularize the test suite. It
> follows a relatively simple model, but it does seem like it will offer
> some degree of flexibility. Plus, no relicensing is necessary.

Hi Jesse,

Junio has just applied relicensing patch for the Git test suite
(http://git.kernel.org/?p=git/git.git;a=commit;h=64b90323f65d2a3ac8d1ff4ed73be881f76aac8a)
so we can use it for notmuch.

I have quickly looked at your modularization and I do not like that each
test resided in a separate file. I've done similar test suite for one of
my projects and it is a pain to modify the tests. If one test depends on
the previous ones, you always have to switch between multiple files in
your editor.

If you agree, I can refresh my git based modularization and send
the patches. What do you (and others) think?

Michal