Return-Path: <m.walters@qmul.ac.uk>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 947CB431FAF
	for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 16:09:51 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -1.098
X-Spam-Level: 
X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
	tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
	NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 6rRvg59+9BA5 for <notmuch@notmuchmail.org>;
	Thu, 19 Jan 2012 16:09:51 -0800 (PST)
Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 05F67431FAE
	for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 16:09:51 -0800 (PST)
Received: from smtp.qmul.ac.uk ([138.37.6.40])
	by mail2.qmul.ac.uk with esmtp (Exim 4.71)
	(envelope-from <m.walters@qmul.ac.uk>)
	id 1Ro238-00030m-4K; Fri, 20 Jan 2012 00:09:46 +0000
Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
	helo=localhost)
	by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
	(envelope-from <m.walters@qmul.ac.uk>)
	id 1Ro237-0004Ig-St; Fri, 20 Jan 2012 00:09:46 +0000
From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH] Automatically exclude tags in notmuch-show
In-Reply-To: <20120119225910.GT16740@mit.edu>
References: <874nvric7c.fsf@qmul.ac.uk>
	<1327010583-23954-1-git-send-email-markwalters1009@gmail.com>
	<20120119225910.GT16740@mit.edu>
User-Agent: Notmuch/0.11+78~g7167de1 (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Fri, 20 Jan 2012 00:10:37 +0000
Message-ID: <871uqvgrnm.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Sender-Host-Address: 94.192.233.223
X-QM-SPAM-Info: Sender has good ham record.  :)
X-QM-Body-MD5: 9b1243ddc46a0e2d9cbfe28645d847ab (of first 20000 bytes)
X-SpamAssassin-Score: -1.8
X-SpamAssassin-SpamBar: -
X-SpamAssassin-Report: The QM spam filters have analysed this message to
	determine if it is
	spam. We require at least 5.0 points to mark a message as spam.
	This message scored -1.8 points.
	Summary of the scoring: 
	* -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
	*      medium trust
	*      [138.37.6.40 listed in list.dnswl.org]
	* 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
	provider *      (markwalters1009[at]gmail.com)
	* -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
	*      domain
	*  0.5 AWL AWL: From: address is in the auto white-list
X-QM-Scan-Virus: ClamAV says the message is clean
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2012 00:09:51 -0000


Ok Having said this is trivial I have found a problem. What should
notmuch do if you do something like

notmuch show id:<some-id>
and that message is marked with a deleted tag? To be consistent with the
other cases (where a deleted message is in a matched thread) we might
want to return the message with the not-matched flag set (eg in
JSON). But my patch doesn't, as it never even sees the thread since it
doesn't match.

Looking at notmuch-show.c I think we should not apply the exclude tags
to do_show_single, but usually should apply it to do_show. One solution
which is simple and is at least close to right would be to get do_show
to return the number of threads found. If this is zero then retry the
query without the excludes (possible setting the match_flag to zero on
each message since we know it does not match)

This is not a completely correct solution as if you ask notmuch-show to
show more than one thread it might  threads which only contain deleted
messages.

I can't see other good possibilities without slowing down the normal
path a lot (eg find all threads that match the original query and then
apply the argument above).

Any thoughts?

Incidentally, is there something strange at the end of notmuch-show.c: I
can't see how we could ever reach the last half dozen lines.

Best wishes

Mark