Date: Mon, 30 Jan 2012 23:34:16 +0100
From: Gregor Zattler <telegraph@gmx.net>
To: notmuch <notmuch@notmuchmail.org>
Subject: Re: Bug?: notmuch-search-show-thread shows several threads; only one
	containing matching messages
Message-ID: <20120130223416.GA26239@shi.workgroup>
Mail-Followup-To: notmuch <notmuch@notmuchmail.org>
References: <20120126004024.GA13704@shi.workgroup>
	<20120126011903.GA1176@mit.edu>
	<8762fzry7k.fsf@servo.finestructure.net>
	<20120126124450.GB30209@shi.workgroup> <87mx9avbc1.fsf@praet.org>
	<20120129234213.GB11460@shi.workgroup> <87zkd5655g.fsf@praet.org>
	<20120130190425.GB13521@shi.workgroup> <878vkoev95.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <878vkoev95.fsf@qmul.ac.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: list

Hi Mark,
* Mark Walters <markwalters1009@gmail.com> [30. Jan. 2012]:
> On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler <telegraph@gmx.net> wrote:
>> * Pieter Praet <pieter@praet.org> [30. Jan. 2012]:
>>> On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler <telegraph@gmx.net> wrote:
>>>> * Pieter Praet <pieter@praet.org> [26. Jan. 2012]:
>>>>> Here's another couple of threads squashed into a single one:
>>>>> - [O] [Use Question] Capture and long lines
>>>>>   - id:"BANLkTikoF4tXuNLLufRzNSD6k2ZYs7sUcg@mail.gmail.com"
>>>>> - [O] Worg update
>>>>>   - id:"m1wrfiz3ch.fsf@tsdye.com"
>>>>> - [O] Table formula to convert hex to dec
>>>>>   - id:"20110724080054.GB16388@x201"
>>>>> - [O] ICS import?
>>>>>   - id:"20120125173421.GQ3747@x201"
>>>>> 
>>>>> 
>>>>> AFAICT, none of them share Message-Id's...
>>>> 
>>>> Do you consider this a bug?
>>>> 
>>> 
>>> I do.  No idea what causes it or how to fix it though... :)
>> 
>> First I thougt it' not a severe bug since one see's more not less
>> messages in notmuch show buffer.  But later I realised one also
>> sees less not more threads in notmuch search buffer and might not
>> read certain notmuch threads because of "wrong" $Subject: in
>> notmuch search buffer.

> I think notmuch links two messages into the same thread if they have an
> in-reply-to or reference header in common: i.e the messages reference a
> common parent message.  (See comment in lib/database.cc "Even before a
> message is added, it's pre-allocated thread ID is useful so that all
> descendant messages that reference this common parent can be recognized
> as belonging to the same thread.")

So in case message a from thread A and message b from B would
name the same Message c in their In-Reoply-To:/References:
headers, while c is not (for some reason) in A or B, notmuch
would assume both threads linked?  Makes sense.
 
> As far as I can see your grep tests haven't checked for that. 

True.

> Also, could you email me the mbox you had (I think you said that it was
> a mailing list so all public) and I will take a look?

Sure, I do so off-list because of the size of the attachment.


Ciao, Gregor
-- 
 -... --- .-. . -.. ..--.. ...-.-