Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D7EE4431FD4 for ; Fri, 24 Oct 2014 03:27:42 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id COsJIk2ROvo4 for ; Fri, 24 Oct 2014 03:27:38 -0700 (PDT) Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id E71D0431FBD for ; Fri, 24 Oct 2014 03:27:37 -0700 (PDT) Received: by mail-wi0-f169.google.com with SMTP id q5so799644wiv.0 for ; Fri, 24 Oct 2014 03:27:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:subject:in-reply-to:references:user-agent :from:date:message-id:mime-version:content-type; bh=CvPxfAyZwUOCMAD9ZAk4xH0difA4Ide/JbnEl5m0WIo=; b=bzUktifxjK1fI8tofHlUtCBPsZhBRvUWtdTkP3ERgEsqovvVYgtssiYLsovWPgzM6C bCSFqFsm8T13DlYjCFZGMXJJTY3ugU0Np1PmdWEbHvqbMhcpbkFflKsRMODhZX6EWT8c lkYH9l4Uj/O95xhapj7ew4gFKCJZmVql3Hu7QRH275hu1L+EO9M0lV6okJzrVQzt0rK5 laIKsb/P+vqyFU8yeI1UPuOW77JvyWsgIPkpH4WzR28WXOOWNBr6ae3ljPk/QpwUgQPG yEr0VaIDsrvQFvoLnzeOUhP/Kq05g3LTjnmgraDhs0ggz13PvlXjLmYDMlL0dwPipjhs hV3A== X-Gm-Message-State: ALoCoQnJzJXImGbgZ3zuK8t4mwM4EPp0giiJHThgchALLn9sqEbfZnvADwEKBGOdDdmropKX3GUy X-Received: by 10.194.205.103 with SMTP id lf7mr1159214wjc.134.1414146117159; Fri, 24 Oct 2014 03:21:57 -0700 (PDT) Received: from disaster-area.hh.sledj.net ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) by mx.google.com with ESMTPSA id q10sm5114251wjq.35.2014.10.24.03.21.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Oct 2014 03:21:56 -0700 (PDT) Received: from localhost (30000@localhost [local]); by localhost (OpenSMTPD) with ESMTPA id 235a0763; Fri, 24 Oct 2014 10:21:54 +0000 (UTC) To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v1 1/3] search: Seperately report matching and non-matching authors. In-Reply-To: <87y4s5vn12.fsf@qmul.ac.uk> References: <1414140488-29978-1-git-send-email-dme@dme.org> <1414140488-29978-2-git-send-email-dme@dme.org> <87y4s5vn12.fsf@qmul.ac.uk> User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-apple-darwin14.0.0) From: David Edmondson Date: Fri, 24 Oct 2014 11:21:54 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2014 10:27:43 -0000 On Fri, Oct 24 2014, Mark Walters wrote: > What about having both authors_matched and authors_not_matched as lists > of authors (ie one string for each author)? That's a sensible idea. I will look into it. > Then emacs, for example, wouldn't try and parse the string back into > authors before splitting. It doesn't really do that other than to decide where to truncate the visible string. That whole chunk of code is horrible. >> first_non_matched_author = 0; > > I think I would prefer to make this look like the matched case and drop > the first_non_matched_author stuff. Agreed, will do.