Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4CD04431FC0 for ; Mon, 6 Oct 2014 11:56:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iPIP+F4mailb for ; Mon, 6 Oct 2014 11:56:27 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 42089431FBF for ; Mon, 6 Oct 2014 11:56:27 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 946B410009D; Mon, 6 Oct 2014 21:56:11 +0300 (EEST) From: Tomi Ollila To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH v2 2/4] cli: Extend the search command for --output=addresses and similar In-Reply-To: <1412542319-20017-3-git-send-email-sojkam1@fel.cvut.cz> References: <874mvqxrnp.fsf@nikula.org> <1412542319-20017-1-git-send-email-sojkam1@fel.cvut.cz> <1412542319-20017-3-git-send-email-sojkam1@fel.cvut.cz> User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Oct 2014 18:56:31 -0000 On Sun, Oct 05 2014, Michal Sojka wrote: > The new outputs allow printing senders, recipients or both of matching > messages. > > This code based on a patch from Jani Nikula. OK, IMO... 1/4 OK Before 2/4 add support for 'flag' arguments, drop the --output=3Daddresses option which is now done as --output=3Dsender --output=3Drecipients In deduplication comment did not describe the deduplication at all... so I looked a bit into the code now... the Default you described was that with "John Doe" and "John Doe" =20 only one was printed (but not which one). Secondly, what happens with "Doe, John" and "John Doe" ... ah, it is same as *addr* with case-insensitive address. Sorry, but IMO these options are a bit strange. Not to go to choose which one to choose (first, last, most common) instead of the suggested options these should be the ones: 1) "John Doe" and "John Doe" := =20 only one printed, but if either were "Dr. John Doe", both of these are prin= ted (this as default). 2) same as above, but only make case-insensitive address match -- i.e. in the 2 above cases in option 1, print only one. (and same name but different address to perhaps never been an option...) I might like to have option that does case-sensitive address match, In those cases I don't know the recipient's culture and the email he sent to me used format (and not knowing which one is the first and which last name (or whatever names these are) -- just to reply in same case format in respect... Tomi > --- > completion/notmuch-completion.bash | 2 +- > completion/notmuch-completion.zsh | 3 +- > doc/man1/notmuch-search.rst | 22 +++++++- > notmuch-search.c | 100 +++++++++++++++++++++++++++++++= +++--- > test/T090-search-output.sh | 64 ++++++++++++++++++++++++ > 5 files changed, 182 insertions(+), 9 deletions(-) > > diff --git a/completion/notmuch-completion.bash b/completion/notmuch-comp= letion.bash > index 0571dc9..c37ddf5 100644 > --- a/completion/notmuch-completion.bash > +++ b/completion/notmuch-completion.bash > @@ -294,7 +294,7 @@ _notmuch_search() > return > ;; > --output) > - COMPREPLY=3D( $( compgen -W "summary threads messages files tags" -= - "${cur}" ) ) > + COMPREPLY=3D( $( compgen -W "summary threads messages files tags se= nder recipients addresses" -- "${cur}" ) ) > return > ;; > --sort) > diff --git a/completion/notmuch-completion.zsh b/completion/notmuch-compl= etion.zsh > index 67a9aba..bff8fd5 100644 > --- a/completion/notmuch-completion.zsh > +++ b/completion/notmuch-completion.zsh > @@ -52,7 +52,8 @@ _notmuch_search() > _arguments -s : \ > '--max-threads=3D[display only the first x threads from the search r= esults]:number of threads to show: ' \ > '--first=3D[omit the first x threads from the search results]:number= of threads to omit: ' \ > - '--sort=3D[sort results]:sorting:((newest-first\:"reverse chronologi= cal order" oldest-first\:"chronological order"))' > + '--sort=3D[sort results]:sorting:((newest-first\:"reverse chronologi= cal order" oldest-first\:"chronological order"))' \ > + '--output=3D[select what to output]:output:((summary threads message= s files tags sender recipients addresses))' > } >=20=20 > _notmuch() > diff --git a/doc/man1/notmuch-search.rst b/doc/man1/notmuch-search.rst > index 90160f2..3447820 100644 > --- a/doc/man1/notmuch-search.rst > +++ b/doc/man1/notmuch-search.rst > @@ -35,7 +35,7 @@ Supported options for **search** include > intended for programs that invoke **notmuch(1)** internally. If > omitted, the latest supported version will be used. >=20=20 > - ``--output=3D(summary|threads|messages|files|tags)`` > + ``--output=3D(summary|threads|messages|files|tags|sender|recipients|= addresses)`` >=20=20 > **summary** > Output a summary of each thread with any message matching > @@ -78,6 +78,26 @@ Supported options for **search** include > by null characters (--format=3Dtext0), as a JSON array > (--format=3Djson), or as an S-Expression list (--format=3Dse= xp). >=20=20 > + **sender** > + Output all addresses from the *From* header that appear on > + any message matching the search terms, either one per line > + (--format=3Dtext), separated by null characters > + (--format=3Dtext0), as a JSON array (--format=3Djson), or as > + an S-Expression list (--format=3Dsexp). > + > + Note: Searching for **sender** should be much faster than > + searching for **recipients** or **addresses**, because > + sender addresses are cached directly in the database > + whereas other addresses need to be fetched from message > + files. > + > + **recipients** > + Like **sender** but for addresses from *To*, *Cc* and > + *Bcc* headers. > + > + **addresses** > + Like **sender** and **recipients** together. > + > ``--sort=3D``\ (**newest-first**\ \|\ **oldest-first**) > This option can be used to present results in either > chronological order (**oldest-first**) or reverse chronological > diff --git a/notmuch-search.c b/notmuch-search.c > index 5ac2a26..0614f10 100644 > --- a/notmuch-search.c > +++ b/notmuch-search.c > @@ -23,11 +23,14 @@ > #include "string-util.h" >=20=20 > typedef enum { > - OUTPUT_SUMMARY, > - OUTPUT_THREADS, > - OUTPUT_MESSAGES, > - OUTPUT_FILES, > - OUTPUT_TAGS > + OUTPUT_SUMMARY =3D 1 << 0, > + OUTPUT_THREADS =3D 1 << 1, > + OUTPUT_MESSAGES =3D 1 << 2, > + OUTPUT_FILES =3D 1 << 3, > + OUTPUT_TAGS =3D 1 << 4, > + OUTPUT_SENDER =3D 1 << 5, > + OUTPUT_RECIPIENTS =3D 1 << 6, > + OUTPUT_ADDRESSES =3D OUTPUT_SENDER | OUTPUT_RECIPIENTS, > } output_t; >=20=20 > typedef struct { > @@ -220,6 +223,67 @@ do_search_threads (search_options_t *o) > return 0; > } >=20=20 > +static void > +print_address_list (const search_options_t *o, InternetAddressList *list) > +{ > + InternetAddress *address; > + int i; > + > + for (i =3D 0; i < internet_address_list_length (list); i++) { > + address =3D internet_address_list_get_address (list, i); > + if (INTERNET_ADDRESS_IS_GROUP (address)) { > + InternetAddressGroup *group; > + InternetAddressList *group_list; > + > + group =3D INTERNET_ADDRESS_GROUP (address); > + group_list =3D internet_address_group_get_members (group); > + if (group_list =3D=3D NULL) > + continue; > + > + print_address_list (o, group_list); > + } else { > + InternetAddressMailbox *mailbox; > + const char *name; > + const char *addr; > + char *full_address; > + > + mailbox =3D INTERNET_ADDRESS_MAILBOX (address); > + > + name =3D internet_address_get_name (address); > + addr =3D internet_address_mailbox_get_addr (mailbox); > + > + if (name && *name) > + full_address =3D talloc_asprintf (o->format, "%s <%s>", name, addr); > + else > + full_address =3D talloc_strdup (o->format, addr); > + > + if (!full_address) { > + fprintf (stderr, "Error: out of memory\n"); > + break; > + } > + o->format->string (o->format, full_address); > + o->format->separator (o->format); > + > + talloc_free (full_address); > + } > + } > +} > + > +static void > +print_address_string (const search_options_t *o, const char *recipients) > +{ > + InternetAddressList *list; > + > + if (recipients =3D=3D NULL) > + return; > + > + list =3D internet_address_list_parse_string (recipients); > + if (list =3D=3D NULL) > + return; > + > + print_address_list (o, list); > +} > + > static int > do_search_messages (search_options_t *o) > { > @@ -266,11 +330,29 @@ do_search_messages (search_options_t *o) >=20=20=09=20=20=20=20 > notmuch_filenames_destroy( filenames ); >=20=20 > - } else { /* output =3D=3D OUTPUT_MESSAGES */ > + } else if (o->output =3D=3D OUTPUT_MESSAGES) { > format->set_prefix (format, "id"); > format->string (format, > notmuch_message_get_message_id (message)); > format->separator (format); > + } else { > + if (o->output & OUTPUT_SENDER) { > + const char *addrs; > + > + addrs =3D notmuch_message_get_header (message, "from"); > + print_address_string (o, addrs); > + } > + > + if (o->output & OUTPUT_RECIPIENTS) { > + const char *hdrs[] =3D { "to", "cc", "bcc" }; > + const char *addrs; > + size_t j; > + > + for (j =3D 0; j < ARRAY_SIZE (hdrs); j++) { > + addrs =3D notmuch_message_get_header (message, hdrs[j]); > + print_address_string (o, addrs); > + } > + } > } >=20=20 > notmuch_message_destroy (message); > @@ -370,6 +452,9 @@ notmuch_search_command (notmuch_config_t *config, int= argc, char *argv[]) > (notmuch_keyword_t []){ { "summary", OUTPUT_SUMMARY }, > { "threads", OUTPUT_THREADS }, > { "messages", OUTPUT_MESSAGES }, > + { "sender", OUTPUT_SENDER }, > + { "recipients", OUTPUT_RECIPIENTS }, > + { "addresses", OUTPUT_ADDRESSES }, > { "files", OUTPUT_FILES }, > { "tags", OUTPUT_TAGS }, > { 0, 0 } } }, > @@ -461,6 +546,9 @@ notmuch_search_command (notmuch_config_t *config, int= argc, char *argv[]) > ret =3D do_search_threads (&o); > break; > case OUTPUT_MESSAGES: > + case OUTPUT_SENDER: > + case OUTPUT_RECIPIENTS: > + case OUTPUT_ADDRESSES: > case OUTPUT_FILES: > ret =3D do_search_messages (&o); > break; > diff --git a/test/T090-search-output.sh b/test/T090-search-output.sh > index 947d572..5458de1 100755 > --- a/test/T090-search-output.sh > +++ b/test/T090-search-output.sh > @@ -387,6 +387,70 @@ cat <EXPECTED > EOF > test_expect_equal_file OUTPUT EXPECTED >=20=20 > +test_begin_subtest "--output=3Dsender" > +notmuch search --output=3Dsender '*' | sort | uniq --count >OUTPUT > +cat <EXPECTED > + 1 Adrian Perez de Castro > + 2 Alex Botero-Lowry > + 4 Alexander Botero-Lowry > + 1 Aron Griffis > + 12 Carl Worth > + 1 Chris Wilson > + 1 Fran=C3=A7ois Boulogne > + 1 Ingmar Vanhassel > + 1 Israel Herraiz > + 4 Jan Janak > + 2 Jjgod Jiang > + 7 Keith Packard > + 5 Lars Kellogg-Stedman > + 5 Mikhail Gusarov > + 1 Olivier Berger > + 1 Rolland Santimano > + 3 Stewart Smith > +EOF > +test_expect_equal_file OUTPUT EXPECTED > + > +test_begin_subtest "--output=3Drecipients" > +notmuch search --output=3Drecipients '*' | sort | uniq --count >OUTPUT > +cat <EXPECTED > + 1 Allan McRae > + 1 Discussion about the Arch User Repository (AUR) > + 1 Keith Packard > + 1 Mikhail Gusarov > + 2 notmuch > + 48 notmuch@notmuchmail.org > + 1 olivier.berger@it-sudparis.eu > +EOF > +test_expect_equal_file OUTPUT EXPECTED > + > +test_begin_subtest "--output=3Daddresses" > +notmuch search --output=3Daddresses '*' | sort | uniq --count >OUTPUT > +cat <EXPECTED > + 1 Adrian Perez de Castro > + 2 Alex Botero-Lowry > + 4 Alexander Botero-Lowry > + 1 Allan McRae > + 1 Aron Griffis > + 12 Carl Worth > + 1 Chris Wilson > + 1 Discussion about the Arch User Repository (AUR) > + 1 Fran=C3=A7ois Boulogne > + 1 Ingmar Vanhassel > + 1 Israel Herraiz > + 4 Jan Janak > + 2 Jjgod Jiang > + 8 Keith Packard > + 5 Lars Kellogg-Stedman > + 6 Mikhail Gusarov > + 1 Olivier Berger > + 1 Rolland Santimano > + 3 Stewart Smith > + 2 notmuch > + 48 notmuch@notmuchmail.org > + 1 olivier.berger@it-sudparis.eu > +EOF > +test_expect_equal_file OUTPUT EXPECTED > + > test_begin_subtest "sanitize output for quoted-printable line-breaks in = author and subject" > add_message "[subject]=3D'two =3D?ISO-8859-1?Q?line=3D0A_subject?=3D > headers'" > --=20 > 2.1.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch