Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id C9CA3429E44
	for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:28:16 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 2.438
X-Spam-Level: **
X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
	tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id J7GHYi6JdbaT for <notmuch@notmuchmail.org>;
	Sat, 10 Jan 2015 01:28:13 -0800 (PST)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 9E332429E41
	for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:28:13 -0800 (PST)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1Y9sL7-0002aG-76; Sat, 10 Jan 2015 05:28:13 -0400
Received: (nullmailer pid 19252 invoked by uid 1000); Sat, 10 Jan 2015
	09:28:08 -0000
From: David Bremner <david@tethera.net>
To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org
Subject: Re: [v2 3/3] thread-naming test: Test empty subject names.
In-Reply-To: <1414615905-22554-4-git-send-email-jrosenthal@jhu.edu>
References: <1414615905-22554-1-git-send-email-jrosenthal@jhu.edu>
	<1414615905-22554-4-git-send-email-jrosenthal@jhu.edu>
User-Agent: Notmuch/0.19+10~g215de26 (http://notmuchmail.org) Emacs/24.4.1
	(x86_64-pc-linux-gnu)
Date: Sat, 10 Jan 2015 10:28:08 +0100
Message-ID: <87h9vzj87r.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Jan 2015 09:28:16 -0000

Jesse Rosenthal <jrosenthal@jhu.edu> writes:

>  
> +test_begin_subtest "Use empty subjects if necessary."
> +add_message '[subject]="@FORCE_EMPTY"' \
> +	    '[date]="Sat, 13 Jan 2001 15:43:45 -0000"' \
> +            '[from]="Empty Sender \<empty_test@notmuchmail.org\

It seems to me we should avoid notmuchmail.org addresses in the test
suite. Maybe this is too picky, but if you are going to fixup the white
space errors, how about also changing to example.{org,net,com}
addresses.

Cheers,

d