Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BE44240D160 for ; Wed, 27 Oct 2010 18:13:45 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MpXHcKLT1y+j; Wed, 27 Oct 2010 18:13:35 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 333C040D155; Wed, 27 Oct 2010 18:13:35 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id C601C2540F4; Wed, 27 Oct 2010 18:13:34 -0700 (PDT) From: Carl Worth To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Avoid runtime use of `cl'. In-Reply-To: <1272537216-2635-1-git-send-email-dme@dme.org> References: <1272537216-2635-1-git-send-email-dme@dme.org> User-Agent: Notmuch/0.3.1-124-gc9e0da3 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Wed, 27 Oct 2010 18:13:34 -0700 Message-ID: <87k4l3glvl.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2010 01:13:46 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 29 Apr 2010 11:33:36 +0100, David Edmondson wrote: > The GNU Emacs Lisp Reference Manual section D.1 says: >=20 > > * Please don't require the cl package of Common Lisp extensions at ... > Follow this advice, requiring the following changes where `cl' was > used at runtime: Thanks for this code, David. I was just sitting down to eliminate all warnings in the compilation of notmuch, so this was very convenient. I've committed this now. I do think the code is a bit harder to read now, but I'm willing to let maintainership of nasty bits of emacs code drift from me to you for things like this. ;-) And meanwhile, the fact that we now have a framework for automated testing of emacs code makes me much more comfortable about changes like this. (Not that I think that we necessarily have good coverage of the code being tested here, but it's now a very small step from where we are to adding that coverage.) Thanks again, =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFMyM4+6JDdNq8qSWgRAhErAJ9EiZ+KXd9e4kvXaYOYBXmfbDCbTQCfSfZi oukfjjQzszHMmYQm6pjBOvs= =KhbT -----END PGP SIGNATURE----- --=-=-=--