Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 6249C6DE0FB1 for ; Thu, 24 Sep 2015 04:30:33 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.118 X-Spam-Level: X-Spam-Status: No, score=0.118 tagged_above=-999 required=5 tests=[AWL=0.108, T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fFiEc76wXxFm for ; Thu, 24 Sep 2015 04:30:31 -0700 (PDT) X-Greylist: delayed 954 seconds by postgrey-1.35 at arlo; Thu, 24 Sep 2015 04:30:31 PDT Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) by arlo.cworth.org (Postfix) with ESMTPS id 9634F6DE0B7C for ; Thu, 24 Sep 2015 04:30:31 -0700 (PDT) Received: from remotemail by gitolite.debian.net with local (Exim 4.80) (envelope-from ) id 1Zf4TL-0006PP-Cs; Thu, 24 Sep 2015 11:13:55 +0000 Received: (nullmailer pid 6555 invoked by uid 1000); Thu, 24 Sep 2015 11:13:34 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: [PATCH] test suite: don't consider skipped individual tests as failing Date: Thu, 24 Sep 2015 08:13:30 -0300 Message-Id: <1443093210-6511-1-git-send-email-david@tethera.net> X-Mailer: git-send-email 2.5.1 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2015 11:30:33 -0000 It isn't completely clear what we want to do here, but 1) We currently don't fail if we skip a whole test file (mainly because we neglect to count those skipped tests properly). This change at least makes the two kinds of skipping consistent. 2) Automated build environments may have good reasons for building with a minimal set of prereqs, and we don't want to discourage running our test suite by breaking builds. --- test/aggregate-results.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/aggregate-results.sh b/test/aggregate-results.sh index b016edb..b30da44 100755 --- a/test/aggregate-results.sh +++ b/test/aggregate-results.sh @@ -82,7 +82,7 @@ if [ "$skipped" != "0" ]; then echo "$skipped $tests skipped." fi -if [ $success -gt 0 -a $fixed -eq 0 -a $failed -eq 0 -a $skipped -eq 0 ] +if [ $success -gt 0 -a $fixed -eq 0 -a $failed -eq 0 ] then exit 0 else -- 2.5.1